Open
Conversation
Owner
|
Thanks for the PR, @davidsanchez222! 🙌 Got it — I'll take a look as soon as I have some time. Appreciate your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
/. i added this because there are some letters like[a, n, d, t, g, q]that wouldn't start searching and would instead give you a popup. this fails when my layout starts with any of these letters. For example, I couldn't search for a layout namednew_layouttype to filterso you can see where you are going to type only after entering filter modectrl-n/ctrl-p,ctrl-j/ctrl-k,tab/shift-tab) so you can select a layout without exiting filter mode. it also wraps around once you reach the endIf you wanted to keep quick search, you could make the
[a, n, d, t, g, q]settings uppercase i.e.[A, N, D, T, G, Q]but again you run the risk of someone having a layout with any of those uppercase letters. having an explicit key to start searching is a better design imo