Skip to content

fix: improve filtering ux#4

Open
davidsanchez222 wants to merge 3 commits intoFranvy:mainfrom
davidsanchez222:fix/improve-filtering
Open

fix: improve filtering ux#4
davidsanchez222 wants to merge 3 commits intoFranvy:mainfrom
davidsanchez222:fix/improve-filtering

Conversation

@davidsanchez222
Copy link
Copy Markdown

Changes made:

  • added a visible filter input line at the top of the left pane so you can see what you’re typing.
  • made filtering explicit so you can only filter once you type /. i added this because there are some letters like [a, n, d, t, g, q] that wouldn't start searching and would instead give you a popup. this fails when my layout starts with any of these letters. For example, I couldn't search for a layout named new_layout
  • added a hint type to filter so you can see where you are going to type only after entering filter mode
  • added navigation key binds (ctrl-n/ctrl-p, ctrl-j/ctrl-k, tab/shift-tab) so you can select a layout without exiting filter mode. it also wraps around once you reach the end
  • finally, i updated the help text and added unit tests to cover this new logic and the removal of quick search.

If you wanted to keep quick search, you could make the [a, n, d, t, g, q] settings uppercase i.e. [A, N, D, T, G, Q] but again you run the risk of someone having a layout with any of those uppercase letters. having an explicit key to start searching is a better design imo

@Franvy
Copy link
Copy Markdown
Owner

Franvy commented Apr 15, 2026

Thanks for the PR, @davidsanchez222! 🙌 Got it — I'll take a look as soon as I have some time. Appreciate your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants