Allow other plugins to suppress FrozenJoin actions and fix bug with FrozenJoinEvent and FrozenQuitEvent#10
Closed
UnknownSilicon wants to merge 1 commit into
Closed
Allow other plugins to suppress FrozenJoin actions and fix bug with FrozenJoinEvent and FrozenQuitEvent#10UnknownSilicon wants to merge 1 commit into
UnknownSilicon wants to merge 1 commit into
Conversation
The way I did this is super jank. Hopefully someone can find a better way to do this.
Owner
|
A way for other plugins to access this will be added, however not via this PR as it seems jank af. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bukkit requires Events to have a static
getHandlersmethod. Previously the method wasn't static so Bukkit would throw an error when the event was being registered.For suppressing FrozenJoin actions on join/quit, the way I did it is super jank. If someone has a better way to this it would be a lot better.