Improve make_playlist.py code quality and fix bugs#989
Merged
KAMI911 merged 3 commits intoFree-TV:masterfrom Mar 8, 2026
Merged
Improve make_playlist.py code quality and fix bugs#989KAMI911 merged 3 commits intoFree-TV:masterfrom
KAMI911 merged 3 commits intoFree-TV:masterfrom
Conversation
Collaborator
KAMI911
commented
Mar 8, 2026
KAMI911
commented
- Fix group name bug: replace underscores with spaces before title() so filenames like north_korea.md produce "North Korea" not "North_Korea"
- Fix resource leaks: use context managers for all file handles including EPG list and per-country playlist files
- Remove os.chdir() global side effect: use absolute paths derived from the script location instead
- Avoid calling to_m3u_line() twice per channel by caching the result
- Fix redundant trailing colon in filename[:-3:] slice
- Consistent use of write() for headers instead of mixing print/write
- Strip blank lines from EPG URL list when reading
added 3 commits
March 8, 2026 07:33
- Fix group name bug: replace underscores with spaces before title() so filenames like north_korea.md produce "North Korea" not "North_Korea" - Fix resource leaks: use context managers for all file handles including EPG list and per-country playlist files - Remove os.chdir() global side effect: use absolute paths derived from the script location instead - Avoid calling to_m3u_line() twice per channel by caching the result - Fix redundant trailing colon in filename[:-3:] slice - Consistent use of write() for headers instead of mixing print/write - Strip blank lines from EPG URL list when reading
Prevents the workflow from failing with exit code 1 when the generated playlist is identical to the previous run and there is nothing to commit.
Replace hardcoded origin/master reference with @{u} (upstream of current
branch) for the diff check, and use HEAD for the push target so the
workflow works correctly on any branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.