Cleaner patch to allow setting backlight to 0. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tream). This version has 'decr' and 'incr' commands, however, which have been left alone with their 0.5% offset since turning off the backlight may well be bad on some hardware and shouldn't be done by accident. Additionally, existing users could use this tool for adjusting their backlights, and removing this 'training wheel' might cause unexpected behavior in normal usage.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner patch to allow setting backlight to 0, in accordance with upstream intel-gpu-tools.
This version has at some point in the past been given 'decr' and 'incr' commands, however – these have been left alone with their pre-existing 0.5% offset since existing users could easily be using this tool for adjusting their backlights, and removing this 'training wheel' might cause unexpected behavior and frustration.
At least, I did find evidence of users using this tool to adjust their backlights when I was reading fora and mailing lists.