Improve backup deletion code#170
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the backup deletion functionality in the Addon Manager by enhancing error handling and ensuring proper path handling. The version has been updated to reflect these improvements.
- Enhanced backup deletion with better error handling and logging
- Replaced direct
shutil.rmtreecalls with utility function for more robust deletion - Updated package version to 2025.08.13
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.xml | Updated version and date to 2025.08.13 |
| AddonManager.py | Improved backup deletion with error handling and utility function usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| """Delete old backups found in the Mod directory.""" | ||
| for backup in backups: | ||
| full_path = os.path.join(fci.DataPaths().mod_dir, backup) | ||
| full_path = str(os.path.join(fci.DataPaths().mod_dir, backup)) |
There was a problem hiding this comment.
The explicit str() conversion is unnecessary since os.path.join() already returns a string. This adds unnecessary complexity without providing any benefit.
Suggested change
| full_path = str(os.path.join(fci.DataPaths().mod_dir, backup)) | |
| full_path = os.path.join(fci.DataPaths().mod_dir, backup) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.