Skip to content

Fix missing CMake entries#172

Merged
chennes merged 1 commit into
FreeCAD:mainfrom
chennes:fixMissingCMake
Aug 14, 2025
Merged

Fix missing CMake entries#172
chennes merged 1 commit into
FreeCAD:mainfrom
chennes:fixMissingCMake

Conversation

@chennes
Copy link
Copy Markdown
Member

@chennes chennes commented Aug 14, 2025

Also removes all testing files from CMake -- the tests are designed to run standalone, not within FreeCAD's testing framework.

Also removes all testing files from CMake -- the tests are designed
to run standalone, not within FreeCAD's testing framework.
Copilot AI review requested due to automatic review settings August 14, 2025 16:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request reorganizes the CMake build configuration by adding missing files to the build target and removing all test-related files from the CMake configuration. The PR indicates that tests are designed to run standalone rather than within FreeCAD's testing framework.

  • Adds missing source files to the CMake configuration
  • Removes all test files and test targets from the build system
  • Reorganizes the file list for better maintainability

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Widgets/CMakeLists.txt Adds missing addonmanager_utility_dialogs.py to the widget sources
CMakeLists.txt Major reorganization: adds missing files, removes all test-related configurations, and alphabetizes the source list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread CMakeLists.txt
AddonManagerOptions_AddCustomRepository.ui
AddonManagerOptions.py
AddonManagerOptions.ui
AddonStats.py
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The source files list is not consistently ordered. Some files appear to be alphabetically sorted while others maintain their original positions. Consider fully alphabetizing the entire list for better maintainability.

Copilot uses AI. Check for mistakes.
@chennes chennes merged commit 98982af into FreeCAD:main Aug 14, 2025
11 checks passed
@chennes chennes deleted the fixMissingCMake branch August 14, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants