Fix missing CMake entries#172
Conversation
Also removes all testing files from CMake -- the tests are designed to run standalone, not within FreeCAD's testing framework.
There was a problem hiding this comment.
Pull Request Overview
This pull request reorganizes the CMake build configuration by adding missing files to the build target and removing all test-related files from the CMake configuration. The PR indicates that tests are designed to run standalone rather than within FreeCAD's testing framework.
- Adds missing source files to the CMake configuration
- Removes all test files and test targets from the build system
- Reorganizes the file list for better maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Widgets/CMakeLists.txt | Adds missing addonmanager_utility_dialogs.py to the widget sources |
| CMakeLists.txt | Major reorganization: adds missing files, removes all test-related configurations, and alphabetizes the source list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| AddonManagerOptions_AddCustomRepository.ui | ||
| AddonManagerOptions.py | ||
| AddonManagerOptions.ui | ||
| AddonStats.py |
There was a problem hiding this comment.
[nitpick] The source files list is not consistently ordered. Some files appear to be alphabetically sorted while others maintain their original positions. Consider fully alphabetizing the entire list for better maintainability.
Also removes all testing files from CMake -- the tests are designed to run standalone, not within FreeCAD's testing framework.