Hide widgets with bad svg#180
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors icon generation code to improve error handling and make it more tolerant of invalid SVG data. The code is extracted from the main AddonManager.py file into a dedicated utilities module to improve maintainability.
Key changes:
- Extract icon utilities into separate module with comprehensive error handling
- Replace simple icon creation with robust validation and fallback mechanisms
- Remove verbose logging statements from metadata loading
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| addonmanager_icon_utilities.py | New utility module containing extracted icon generation code with improved error handling and SVG validation |
| AddonManagerTest/gui/test_icon_utilities.py | Comprehensive test suite for the new icon utilities module |
| AddonManager.py | Remove icon generation code and update imports to use new utilities module |
| AddonCatalog.py | Remove verbose logging statements from metadata loading |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the icon generation code to pull it out of the main AddonManager.py file, and to make it much more error-tolerant (and to make the errors it doesn't handle clearer to the end user who has to see them).