Skip to content

Hide widgets with bad svg#180

Merged
chennes merged 3 commits into
FreeCAD:mainfrom
chennes:hideWidgetsWithBadSVG
Aug 17, 2025
Merged

Hide widgets with bad svg#180
chennes merged 3 commits into
FreeCAD:mainfrom
chennes:hideWidgetsWithBadSVG

Conversation

@chennes
Copy link
Copy Markdown
Member

@chennes chennes commented Aug 17, 2025

Refactor the icon generation code to pull it out of the main AddonManager.py file, and to make it much more error-tolerant (and to make the errors it doesn't handle clearer to the end user who has to see them).

Copilot AI review requested due to automatic review settings August 17, 2025 03:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors icon generation code to improve error handling and make it more tolerant of invalid SVG data. The code is extracted from the main AddonManager.py file into a dedicated utilities module to improve maintainability.

Key changes:

  • Extract icon utilities into separate module with comprehensive error handling
  • Replace simple icon creation with robust validation and fallback mechanisms
  • Remove verbose logging statements from metadata loading

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
addonmanager_icon_utilities.py New utility module containing extracted icon generation code with improved error handling and SVG validation
AddonManagerTest/gui/test_icon_utilities.py Comprehensive test suite for the new icon utilities module
AddonManager.py Remove icon generation code and update imports to use new utilities module
AddonCatalog.py Remove verbose logging statements from metadata loading

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread addonmanager_icon_utilities.py
Comment thread addonmanager_icon_utilities.py Outdated
@chennes chennes merged commit be2af41 into FreeCAD:main Aug 17, 2025
11 checks passed
@chennes chennes deleted the hideWidgetsWithBadSVG branch August 17, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants