Clean up license norming diagnostic output#181
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves diagnostic output for license normalization by making it clear which addons have unrecognized or non-normalizable license identifiers. The changes modify the license normalization process to provide informative output about license validation failures and successful normalizations.
Key changes:
- Modified license normalization to return
Nonefor unrecognizable licenses instead of the original string - Added diagnostic output to identify which addons have problematic license identifiers
- Updated callers to handle the new return type and provide meaningful feedback
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| addonmanager_licenses.py | Changed normalize method to return Optional[str] and removed internal logging |
| addonmanager_metadata.py | Added diagnostic output for license normalization issues with addon names |
| addonmanager_macro_parser.py | Added warning/info messages for license normalization failures and successes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was impossible to tell which addons had unrecognized or un-normalizable licenses before: this modifies the diagnostic output so it's clear which addons have non-SPDX license identifiers.