Skip to content

Clean up license norming diagnostic output#181

Merged
chennes merged 1 commit into
FreeCAD:mainfrom
chennes:cleanupLicenseNormingOutput
Aug 17, 2025
Merged

Clean up license norming diagnostic output#181
chennes merged 1 commit into
FreeCAD:mainfrom
chennes:cleanupLicenseNormingOutput

Conversation

@chennes
Copy link
Copy Markdown
Member

@chennes chennes commented Aug 17, 2025

It was impossible to tell which addons had unrecognized or un-normalizable licenses before: this modifies the diagnostic output so it's clear which addons have non-SPDX license identifiers.

Copilot AI review requested due to automatic review settings August 17, 2025 04:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves diagnostic output for license normalization by making it clear which addons have unrecognized or non-normalizable license identifiers. The changes modify the license normalization process to provide informative output about license validation failures and successful normalizations.

Key changes:

  • Modified license normalization to return None for unrecognizable licenses instead of the original string
  • Added diagnostic output to identify which addons have problematic license identifiers
  • Updated callers to handle the new return type and provide meaningful feedback

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
addonmanager_licenses.py Changed normalize method to return Optional[str] and removed internal logging
addonmanager_metadata.py Added diagnostic output for license normalization issues with addon names
addonmanager_macro_parser.py Added warning/info messages for license normalization failures and successes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread addonmanager_metadata.py
@chennes chennes merged commit 1248b99 into FreeCAD:main Aug 17, 2025
11 checks passed
@chennes chennes deleted the cleanupLicenseNormingOutput branch August 17, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants