Conversation
06d4e27 to
909f901
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Addon Manager’s internal workbench dependency handling and warning output, and bumps the package metadata version/date.
Changes:
- Add
MeshPartto the recognized internal workbench dependency list. - Adjust the “Unrecognized internal workbench” warning formatting to include a trailing newline.
- Update
package.xmlversion/date for the dev build.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.xml | Bumps addon version/date metadata. |
| Addon.py | Extends internal workbench mapping and tweaks warning message formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "AddonsInstaller", | ||
| "{}: Unrecognized internal workbench '{}'", | ||
| "{}: Unrecognized internal workbench '{}'\n", | ||
| ).format(self.name, dep.package) |
There was a problem hiding this comment.
Including the trailing newline inside the translatable string changes the translation key (msgid) and will drop existing translations for this warning. Prefer keeping the msgid unchanged and append the newline outside translate(...).format(...) when calling PrintWarning.
| "import": "Import", | ||
| "material": "Material", | ||
| "mesh": "Mesh", | ||
| "meshpart": "MeshPart", |
There was a problem hiding this comment.
Adding a new INTERNAL_WORKBENCHES entry will break the unit test test_internal_workbench_list, which loads depends_on_all_workbenches.xml and asserts that it contains every internal workbench. Please update that XML fixture (or relax the assertion) to include a MeshPart dependency so CI remains green.
909f901 to
d99424c
Compare
|
Successfully created backport PR for |
Add
MeshPartto the recognized list, and correct formatting of the error message.