Backport missing to main#388
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports cache-generation and validation updates into the Addon Manager, along with the package release metadata update.
Changes:
- Updates package version/date to 2026.5.13.
- Adds icon validation, macro logging/error aggregation, PNG iCCP detection, and git hash/tag capture for cache generation.
- Updates and adds tests for cache generation, icon analysis, and FreeCAD logging behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.xml |
Updates release version and date. |
MacroCacheCreator.py |
Captures macro warnings/errors, validates icon data, handles XPM icons, and initializes Qt for icon checks. |
AddonManagerTest/gui/test_icon_utilities.py |
Adds PNG chunk/iCCP tests. |
AddonManagerTest/app/test_macro_cache_creator.py |
Adds macro error logging tests. |
AddonManagerTest/app/test_freecad_interface.py |
Updates logging tests to assert named logger output. |
AddonManagerTest/app/test_addon_catalog_cache_creator.py |
Updates cache writer tests for instance directory naming and SVG icon data. |
addonmanager_macro_parser.py |
Defaults missing macro licenses and improves license log messages. |
addonmanager_icon_utilities.py |
Adds PNG chunk parsing and duplicate iCCP detection. |
addonmanager_freecad_interface.py |
Routes fallback console logging through the addonmanager logger. |
AddonCatalogCacheCreator.py |
Adds git info capture, directory-name sanitization, and icon validation before embedding cache icons. |
AddonCatalog.py |
Adds generated git hash/tag fields and catalog mutation helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
426
to
+429
| if catalog_entry.branch_display_name: | ||
| expected_name += catalog_entry.branch_display_name.replace("/", "-") | ||
| expected_name += catalog_entry.branch_display_name | ||
| elif catalog_entry.git_ref: | ||
| expected_name += catalog_entry.git_ref.replace("/", "-") | ||
| expected_name += catalog_entry.git_ref |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks a number of missing commits whose backport failed.