Skip to content

Backport missing to main#388

Merged
chennes merged 4 commits into
FreeCAD:mainfrom
chennes:backport-missing-to-main
May 13, 2026
Merged

Backport missing to main#388
chennes merged 4 commits into
FreeCAD:mainfrom
chennes:backport-missing-to-main

Conversation

@chennes
Copy link
Copy Markdown
Member

@chennes chennes commented May 13, 2026

This cherry-picks a number of missing commits whose backport failed.

Copilot AI review requested due to automatic review settings May 13, 2026 19:33
@chennes chennes merged commit 2121cb2 into FreeCAD:main May 13, 2026
10 checks passed
@chennes chennes deleted the backport-missing-to-main branch May 13, 2026 19:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports cache-generation and validation updates into the Addon Manager, along with the package release metadata update.

Changes:

  • Updates package version/date to 2026.5.13.
  • Adds icon validation, macro logging/error aggregation, PNG iCCP detection, and git hash/tag capture for cache generation.
  • Updates and adds tests for cache generation, icon analysis, and FreeCAD logging behavior.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.xml Updates release version and date.
MacroCacheCreator.py Captures macro warnings/errors, validates icon data, handles XPM icons, and initializes Qt for icon checks.
AddonManagerTest/gui/test_icon_utilities.py Adds PNG chunk/iCCP tests.
AddonManagerTest/app/test_macro_cache_creator.py Adds macro error logging tests.
AddonManagerTest/app/test_freecad_interface.py Updates logging tests to assert named logger output.
AddonManagerTest/app/test_addon_catalog_cache_creator.py Updates cache writer tests for instance directory naming and SVG icon data.
addonmanager_macro_parser.py Defaults missing macro licenses and improves license log messages.
addonmanager_icon_utilities.py Adds PNG chunk parsing and duplicate iCCP detection.
addonmanager_freecad_interface.py Routes fallback console logging through the addonmanager logger.
AddonCatalogCacheCreator.py Adds git info capture, directory-name sanitization, and icon validation before embedding cache icons.
AddonCatalog.py Adds generated git hash/tag fields and catalog mutation helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 426 to +429
if catalog_entry.branch_display_name:
expected_name += catalog_entry.branch_display_name.replace("/", "-")
expected_name += catalog_entry.branch_display_name
elif catalog_entry.git_ref:
expected_name += catalog_entry.git_ref.replace("/", "-")
expected_name += catalog_entry.git_ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants