Skip to content

Gui: fix skip grabMouse on Wayland#26534

Merged
sliptonic merged 1 commit intoFreeCAD:mainfrom
alfrix:wayland_fix
Jan 26, 2026
Merged

Gui: fix skip grabMouse on Wayland#26534
sliptonic merged 1 commit intoFreeCAD:mainfrom
alfrix:wayland_fix

Conversation

@alfrix
Copy link
Copy Markdown
Contributor

@alfrix alfrix commented Dec 29, 2025

this fixes some instances of the warning message of This plugin supports grabbing the mouse only for popup windows

it seems one instance of this warning remains in the treeview splitter/dragger but i cannot find what causes that one

@luzpaz luzpaz added OS: Linux Topic: Wayland Issues/PRs related to Linux Wayland labels Dec 29, 2025
@github-actions github-actions bot added the Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Dec 29, 2025
@maxwxyz maxwxyz added Type: Bug This issue or PR is related to a bug backport releases/FreeCAD-1-1 Applied to a PR that is on main to trigger the automatic creation of another PR onto 1.1 labels Dec 30, 2025
@maxwxyz maxwxyz added this to the 1.1 milestone Dec 30, 2025
@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue Dec 30, 2025
@alfrix alfrix changed the title Gui: skip grabMouse on Wayland Gui: fix skip grabMouse on Wayland Dec 30, 2025
@kadet1090
Copy link
Copy Markdown
Member

Anyone able to test it on wayland? @ryankembrey @obelisk79?

@kadet1090 kadet1090 added Approved: Code Quality The PR was checked for code quality and approved Requires: Testing The PR needs testing by users and developers labels Jan 2, 2026
@kadet1090 kadet1090 self-assigned this Jan 2, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Jan 2, 2026
@chennes chennes requested a review from adrianinsaval January 5, 2026 16:46
@maxwxyz maxwxyz requested a review from adrianinsaval January 5, 2026 16:46
@chennes
Copy link
Copy Markdown
Member

chennes commented Jan 19, 2026

@theo-vt is a Wayland user and will test this out.

@theo-vt
Copy link
Copy Markdown
Contributor

theo-vt commented Jan 20, 2026

hi @alfrix! I've looked on the issue page & the forum to find where this error pops up but I can't seem to trigger it, are there specific cases you were looking into?

@alfrix
Copy link
Copy Markdown
Contributor Author

alfrix commented Jan 20, 2026

hi @alfrix! I've looked on the issue page & the forum to find where this error pops up but I can't seem to trigger it, are there specific cases you were looking into?

This happens with the tree in overlay transparent mode

Videocaptura.de.pantalla_20260120_111012.webm

wayland cannot grabmouse i've read that is due to security concerns, so this is specifically needs to be disabled, but long term we may need to rethink the entire functionality and rewrite all the parts that grabMouse or fake a mouse press, which will never work on wayland

@theo-vt
Copy link
Copy Markdown
Contributor

theo-vt commented Jan 25, 2026

Hey! I could not generate the error, I don't know much about display servers so maybe I have some compatibility setting somewhere or something - either way I can't tell if the fix worked or not,

@sliptonic sliptonic merged commit 1446a91 into FreeCAD:main Jan 26, 2026
20 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Merge Queue Jan 26, 2026
@freecad-ci-runner
Copy link
Copy Markdown
Collaborator

Successfully created backport PR for releases/FreeCAD-1-1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Code Quality The PR was checked for code quality and approved backport releases/FreeCAD-1-1 Applied to a PR that is on main to trigger the automatic creation of another PR onto 1.1 Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD OS: Linux Requires: Testing The PR needs testing by users and developers Topic: Wayland Issues/PRs related to Linux Wayland Type: Bug This issue or PR is related to a bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants