Skip to content

Measurement: Added support for cylindrical surfaces#27044

Merged
maxwxyz merged 6 commits intoFreeCAD:mainfrom
MortenVajhoj:main
Jan 24, 2026
Merged

Measurement: Added support for cylindrical surfaces#27044
maxwxyz merged 6 commits intoFreeCAD:mainfrom
MortenVajhoj:main

Conversation

@MortenVajhoj
Copy link
Copy Markdown
Contributor

I have added support for picking cylindrical surfaces when measuring radius or diameter. And changed the placement of annotation
This means that the user can pick a cylindrical face, an'd get the diameter and radius from the face

Issues

#13724

Before and After Images

I dont know if this counts as UI change but the placement of the annotation has changed
Before
image

After
image

This change was also mentioned in the above issue

@github-actions github-actions bot added Mod: Part Related to the Part Workbench Mod: Measurement Regarding Measurment functionality labels Jan 20, 2026
@MortenVajhoj MortenVajhoj changed the title Added support for cylindrical surfaces Measurement: Added support for cylindrical surfaces Jan 20, 2026
@maxwxyz
Copy link
Copy Markdown
Collaborator

maxwxyz commented Jan 20, 2026

@hlorus FYI

@maxwxyz maxwxyz added the Type: Feature FR for improvements or new features label Jan 20, 2026
@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue Jan 20, 2026
@maxwxyz maxwxyz added this to the 1.2 milestone Jan 20, 2026
@maxwxyz maxwxyz linked an issue Jan 20, 2026 that may be closed by this pull request
2 tasks
@maxwxyz
Copy link
Copy Markdown
Collaborator

maxwxyz commented Jan 20, 2026

@MortenVajhoj does it work with the top face or also the cylindrical side face?

@MortenVajhoj
Copy link
Copy Markdown
Contributor Author

MortenVajhoj commented Jan 20, 2026

@MortenVajhoj does it work with the top face or also the cylindrical side face?

It works with the cylindrical faces, but not the top face (The round circle on top). But maybe that should also be added?

But currently when you click on the cylindrical face it measures it

So when you click on the side
image

@maxwxyz
Copy link
Copy Markdown
Collaborator

maxwxyz commented Jan 20, 2026

Thanks for clarifying. Based on the images I thought the top face was selected. Does this also work for fillets or only closed cylinders?

@MortenVajhoj
Copy link
Copy Markdown
Contributor Author

Fillets do not work currently, but that could be interesting to look at

@MortenVajhoj
Copy link
Copy Markdown
Contributor Author

It does not only work with fully closed it also works with "Arc From Center" and "Arc From 3 Points"

@maxwxyz maxwxyz added the Approved: UI/UX The Issue/PR was reviewed in terms of UI/UX and approved by the Design Working Group label Jan 20, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Jan 20, 2026
Copy link
Copy Markdown
Collaborator

@maxwxyz maxwxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@maxwxyz maxwxyz added the Approved: Tested The PR was manually tested and approved label Jan 24, 2026
@kadet1090 kadet1090 added the Approved: Code Quality The PR was checked for code quality and approved label Jan 24, 2026
@maxwxyz maxwxyz merged commit 356fe85 into FreeCAD:main Jan 24, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Merge Queue Jan 24, 2026
paullee0 pushed a commit to paullee0/FreeCAD that referenced this pull request Feb 2, 2026
* Added support for cylindrical surfaces

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removed unnessecary sign

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Reverted change

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Code Quality The PR was checked for code quality and approved Approved: Tested The PR was manually tested and approved Approved: UI/UX The Issue/PR was reviewed in terms of UI/UX and approved by the Design Working Group Mod: Measurement Regarding Measurment functionality Mod: Part Related to the Part Workbench Type: Feature FR for improvements or new features

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Measurement: Support radius/diameter, also for cylindrical surfaces

3 participants