Skip to content

Gui: Enable multi-selection for AlignToSelection#29182

Merged
kadet1090 merged 1 commit intoFreeCAD:mainfrom
maxwxyz:align-view
Apr 22, 2026
Merged

Gui: Enable multi-selection for AlignToSelection#29182
kadet1090 merged 1 commit intoFreeCAD:mainfrom
maxwxyz:align-view

Conversation

@maxwxyz
Copy link
Copy Markdown
Contributor

@maxwxyz maxwxyz commented Apr 8, 2026

Add multi-selection support to Std AlignToSelection.
Uses average direction of faces, aligns to plane normal if multiple edges are in one plane (e.g. a sketch).
🤖 AI

Issues

Fixes #11234

Before and After Images

Bildschirmaufnahme.2026-04-08.um.18.48.05.mov

@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue Apr 8, 2026
@maxwxyz maxwxyz added the Type: Feature FR for improvements or new features label Apr 8, 2026
@github-actions github-actions Bot added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Mod: Part Related to the Part Workbench labels Apr 8, 2026
@maxwxyz maxwxyz added this to the 1.2 milestone Apr 8, 2026
@Rexbas
Copy link
Copy Markdown
Contributor

Rexbas commented Apr 8, 2026

Works great.

@maxwxyz maxwxyz marked this pull request as ready for review April 8, 2026 17:44
@maxwxyz maxwxyz added the Approved: Tested The PR was manually tested and approved label Apr 8, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Apr 8, 2026
Copy link
Copy Markdown
Contributor

@FEA-eng FEA-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected

Copy link
Copy Markdown
Member

@kadet1090 kadet1090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is that the code is overcomplex for the thing it achieves, it feels quite duplicated. Should be probably first structured properly to reduce duplications.

Comment thread src/Gui/View3DInventorViewer.cpp Outdated
Comment thread src/Mod/Part/App/PartFeature.cpp Outdated
Comment thread src/Mod/Part/App/PartFeature.cpp Outdated
Comment thread src/Mod/Part/App/PartFeature.cpp Outdated
@github-project-automation github-project-automation Bot moved this from Approved to Queue in Merge Queue Apr 8, 2026
@maxwxyz
Copy link
Copy Markdown
Contributor Author

maxwxyz commented Apr 10, 2026

@kadet1090 moved to GeoFeature

@maxwxyz maxwxyz moved this from Queue to Approved in Merge Queue Apr 10, 2026
@kadet1090 kadet1090 merged commit f182492 into FreeCAD:main Apr 22, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Merge Queue Apr 22, 2026
@maxwxyz maxwxyz deleted the align-view branch April 23, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Tested The PR was manually tested and approved Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Mod: Part Related to the Part Workbench Type: Feature FR for improvements or new features

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Core: Improve Align Camera View to Selected Reference (Face, Datum)

4 participants