Skip to content

Measure: improve label drag#29228

Merged
hyarion merged 1 commit intoFreeCAD:mainfrom
YashSuthar983:Measure_label
Apr 15, 2026
Merged

Measure: improve label drag#29228
hyarion merged 1 commit intoFreeCAD:mainfrom
YashSuthar983:Measure_label

Conversation

@YashSuthar983
Copy link
Copy Markdown
Contributor

Improved label drag as earlier the label drag plane always changing with respect to camera so label position changing when we just rotate view.
this fixes by introducing snapshot behaviour as when we start drage we orient the dragger plane and drag along this plane.

Before

2026-04-10.00-39-25.mp4

After

2026-04-10.00-41-32.mp4

Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>
@nishendra3
Copy link
Copy Markdown
Contributor

Thanks for fixing this. Should close the regression caused by #27832

@maxwxyz maxwxyz added the Approved: Tested The PR was manually tested and approved label Apr 10, 2026
@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue Apr 10, 2026
@maxwxyz maxwxyz added this to the 1.2 milestone Apr 10, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Apr 10, 2026
Comment thread src/Mod/Measure/Gui/ViewProviderMeasureBase.cpp
@maxwxyz maxwxyz added Approved: Code Quality The PR was checked for code quality and approved Approved: UI/UX The Issue/PR was reviewed in terms of UI/UX and approved by the Design Working Group labels Apr 10, 2026
@hyarion hyarion merged commit bec9892 into FreeCAD:main Apr 15, 2026
36 of 37 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Merge Queue Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Code Quality The PR was checked for code quality and approved Approved: Tested The PR was manually tested and approved Approved: UI/UX The Issue/PR was reviewed in terms of UI/UX and approved by the Design Working Group Mod: Measurement Regarding Measurment functionality

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants