PartDesign: fix Length/Length2 expression migration for TwoLengths pads#29247
Merged
kadet1090 merged 1 commit intoFreeCAD:mainfrom Apr 13, 2026
Merged
Conversation
github-actions
bot
added
the
Mod: Part Design
maxwxyz
added
Type: Bug
Member
|
worked for me but I only tested pretty simple files |
Bojan9597
force-pushed
the
fix/partdesign-twolengths-expression-migration
branch
from
542efe3 to
79ce4e2
Compare
Collaborator
|
@Bojan9597 CI fails |
Bojan9597
force-pushed
the
fix/partdesign-twolengths-expression-migration
branch
from
79ce4e2 to
1a641f8
Compare
Contributor
Author
|
Fixed, it was not up to me |
kadet1090
approved these changes
Apr 13, 2026
Collaborator
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29233
When opening a v1.0 TwoLengths pad, two expression cases broke during migration:
Length2 = Length / 2moved toLengthas-is →Length = Length / 2(cyclic, silently discarded)Pad.Length2were never updatedFix: call
renameObjectIdentifiers({Length↔Length2})document-wide before swapping the expression bindings. I added two regression tests covering both failure modes.