Sketcher: Polyline rework. by PaddleStroke · Pull Request #29336 · FreeCAD/FreeCAD

PaddleStroke · 2026-04-13T15:38:26Z

This PR adds a new command Sketcher_CreatePolyline2
Why? Because I am sure many people will yell murder if their polyline tool is removed and I don't want to deal with it.

So this PR is not touching the existing tool and adds another tool. In the toolbar, we are replacing the command in the line command group. The individual command remain untouched.

This PR also adds autoconstraints such as tangent, parallel and perpendicular.

Fix #12462

for more information, see https://pre-commit.ci

tigert · 2026-04-13T16:17:46Z

can you post a demonstration video of the features?

edit: https://www.youtube.com/watch?v=18WdpAEWxRg < is this it?

PaddleStroke · 2026-04-13T16:27:20Z

Yes this is the video

FEA-eng · 2026-04-13T16:46:26Z

CI failed and I keep getting these warnings after starting FreeCAD compile with this PR:

QPixmap::scaled: Pixmap is a null pixmap

FEA-eng · 2026-04-13T16:48:46Z

In the toolbar, we are replacing the command in the line command group. The individual command remain untouched.

So the new polyline is available only if the line grouping preference is enabled?

This PR also adds autoconstraints such as tangent, parallel and perpendicular.

This is even better for me. But I know that some users don't like autoconstraints. How about a preference to disable them? #21761

PaddleStroke · 2026-04-13T16:50:35Z

So the new polyline is available only if the line grouping preference is enabled?

Yes current code is like this.
Although we can change that to whatever DWG wants.

PaddleStroke · 2026-04-13T16:52:06Z

CI failed and I keep getting these warnings after starting FreeCAD compile with this PR:

QPixmap::scaled: Pixmap is a null pixmap

Hmm CI failure is probably unrelated because it doesn't make sense.

I don't know what is this warning about pixmap I don't think I used scaled there.

The PR was opened at 5:38 so during the merge meeting so maybe I rebased on main at the wrong time.

PaddleStroke · 2026-04-13T16:52:39Z

This is even better for me. But I know that some users don't like autoconstraints. How about a preference to disable them?

Sounds good. But perhaps not in this huge PR

FEA-eng · 2026-04-13T17:40:56Z

The new tool has the same problem as the Text tool used to have: #28363

But not just for Y coordinate - the angle input also has it. Although it blends with #29248, so it's hard to say.

…x ovp issue

PaddleStroke · 2026-04-14T13:11:10Z

Thanks @FEA-eng I fixed it

FEA-eng · 2026-04-14T18:36:57Z

There's still something off with the OVPs (apart from the known jumping cursor issue):

Notice two things:

the line can be extended/shortened even after entering its length
at the end, some OVP with 0 appears at the origin

PaddleStroke · 2026-04-15T12:12:12Z

Let's see. The bug where the line changes length, I remember the line tool had the same regresion following earlier OVP changes.
I'll check how to fix that regression

PaddleStroke · 2026-04-15T12:15:31Z

Indeed that regression has been fixed by #24904
So looks like I have to study that PR which is not straight forward and apply the same to the new polyline.

PaddleStroke · 2026-04-15T12:44:25Z

It appears to be fixed

for more information, see https://pre-commit.ci

FEA-eng · 2026-04-18T16:44:50Z

It appears to be fixed

Indeed, the length change is fixed, but I still see this weird OVP at the origin (and can even switch to it):

PaddleStroke · 2026-04-20T12:50:05Z

Can you please describe precise reproduction steps for the additional spinbox? I can't seem to reproduce it now.

FEA-eng · 2026-04-20T19:06:55Z

Can you please describe precise reproduction steps for the additional spinbox? I can't seem to reproduce it now.

Sure:

Enter some values for the two position OVPs for the starting point. I used X=40 mm and Y=50 mm
Click or press Enter to confirm.
Now move or rotate the view. The additional OVP should appear at the origin.

obelisk79 · 2026-05-15T03:19:28Z

I got to work with this earlier today after building it locally, and I have to say this imo offers a very noteworthy UX improvement to this tool. I hope we can nest the regular line tool under this one on the toolbar like we did with the new coincident constraint tool in the very near future. These changes make polyline a far superior tool in the overwhelming majority of cases where lines and arcs will be needed. Well done @PaddleStroke !

maxwxyz

Merge after these changes

Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>

PaddleStroke · 2026-05-18T16:27:59Z

@maxwxyz your changes are commited

Document the new reworked Polyline tool with OVP support and autoconstraints. Source: FreeCAD/FreeCAD#29336 Refs: FreeCAD/FreeCAD#12462

TomPcz · 2026-05-21T04:58:53Z

I might be missing something, but I think “R undoes the last point” does not seem to do anything.

M for mode works (well, only after the first line, I cannot start with an arc, but that makes sense). F for fillet works only before I start drawing (but I can still click on that option, and it works as expected). R does not.

maxwxyz · 2026-05-21T05:11:08Z

Can conform @PaddleStroke FYI

PaddleStroke · 2026-05-21T08:52:07Z

Thanks for the feedback. Hmm it must have broke during the various fixes we did in this PR. Let me check this.

PaddleStroke · 2026-05-21T11:01:35Z

This is not specific to the polyline tool. All the tools are affected: shortcuts do not work (example rectangle tool U and J).
It is a focus issue. I will create an issue about it

Sketcher: Polyline rework.

1728163

github-project-automation Bot added this to Merge Queue Apr 13, 2026

github-project-automation Bot moved this to Queue in Merge Queue Apr 13, 2026

github-actions Bot added the Mod: Sketcher Related to the Sketcher Workbench label Apr 13, 2026

[pre-commit.ci] auto fixes from pre-commit.com hooks

28dff12

for more information, see https://pre-commit.ci

PaddleStroke mentioned this pull request Apr 13, 2026

Maintenance, improvement and development Assembly & Sketcher - 2026 Q1 FreeCAD/FPA-grant-proposals#79

Open

maxwxyz added Type: Feature FR for improvements or new features Requires: UI/UX review Issue/PR to be reviewed in terms of UI/UX by the Design Working Group or under refinement. labels Apr 13, 2026

maxwxyz added this to the 1.2 milestone Apr 13, 2026

maxwxyz moved this from Queue to Merge Meeting in Merge Queue Apr 13, 2026

github-project-automation Bot added this to UI / UX Improvements Apr 13, 2026

Sketcher: New polyline tool: change isSet to hasFinishedEditing to fi…

4061ad9

…x ovp issue

Sketcher: Polyline2: port the OVP fix from 24904

dd9fb26

[pre-commit.ci] auto fixes from pre-commit.com hooks

2c213b9

for more information, see https://pre-commit.ci

kadet1090 self-assigned this May 18, 2026

kadet1090 added the Requires: Code Review The PR requires code to be reviewed label May 18, 2026

maxwxyz reviewed May 18, 2026

View reviewed changes

PaddleStroke and others added 5 commits May 18, 2026 18:27

Update src/Mod/Sketcher/Gui/CommandCreateGeo.cpp

f9b0f49

Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>

Update src/Mod/Sketcher/Gui/CommandCreateGeo.cpp

7885872

Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>

Update src/Mod/Sketcher/Gui/DrawSketchHandlerLineSet.h

50ebe97

Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>

Update src/Mod/Sketcher/Gui/DrawSketchHandlerLineSet.h

b872874

Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>

Update src/Mod/Sketcher/Gui/DrawSketchHandlerLineSet.h

e652f1a

Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>

kadet1090 approved these changes May 18, 2026

View reviewed changes

kadet1090 added Approved: Code Quality The PR was checked for code quality and approved and removed Requires: Code Review The PR requires code to be reviewed labels May 18, 2026

maxwxyz enabled auto-merge (squash) May 18, 2026 16:55

maxwxyz merged commit d77c964 into FreeCAD:main May 18, 2026
24 checks passed

github-project-automation Bot moved this to Done in UI / UX Improvements May 18, 2026

github-project-automation Bot moved this from Approved to Done in Merge Queue May 18, 2026

Alex-2Code mentioned this pull request May 19, 2026

docs: add Sketcher CreatePolyline2 tool documentation Reqrefusion/FreeCAD-Documentation-Project#117

Draft

TomPcz mentioned this pull request May 20, 2026

Sketcher: Unhandled exception in polyline tool #30323

Open

PaddleStroke mentioned this pull request May 21, 2026

Sketcher: widget key shortcuts not working anymore. #30340

Open

This was referenced May 21, 2026

Sketcher: re-add hints for Polyline #30344

Open

Sketcher: Remove legacy Polyline tool #30346

Open

Uh oh!

Conversation

PaddleStroke commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tigert commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaddleStroke commented Apr 13, 2026

Uh oh!

FEA-eng commented Apr 13, 2026

Uh oh!

FEA-eng commented Apr 13, 2026

Uh oh!

PaddleStroke commented Apr 13, 2026

Uh oh!

PaddleStroke commented Apr 13, 2026

Uh oh!

PaddleStroke commented Apr 13, 2026

Uh oh!

FEA-eng commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaddleStroke commented Apr 14, 2026

Uh oh!

FEA-eng commented Apr 14, 2026

Uh oh!

PaddleStroke commented Apr 15, 2026

Uh oh!

PaddleStroke commented Apr 15, 2026

Uh oh!

PaddleStroke commented Apr 15, 2026

Uh oh!

FEA-eng commented Apr 18, 2026

Uh oh!

PaddleStroke commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FEA-eng commented Apr 20, 2026

Uh oh!

obelisk79 commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxwxyz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PaddleStroke commented May 18, 2026

Uh oh!

Uh oh!

TomPcz commented May 21, 2026

Uh oh!

maxwxyz commented May 21, 2026

Uh oh!

PaddleStroke commented May 21, 2026

Uh oh!

PaddleStroke commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

PaddleStroke commented Apr 13, 2026 •

edited

Loading

tigert commented Apr 13, 2026 •

edited

Loading

FEA-eng commented Apr 13, 2026 •

edited

Loading

PaddleStroke commented Apr 20, 2026 •

edited

Loading

obelisk79 commented May 15, 2026 •

edited

Loading