Assembly: Fix crash on right click assembly link#29887
Merged
Merged
Conversation
Contributor
|
It fixes the right-click crash, but it crashes or shows the errors below if I double-click on the subassembly. |
Contributor
Author
This is a different bug. See #29901 |
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #29702
Note before
cmd->getAction()never returned null. I think before cmd was null if there was no action.So what happens is that if you have not loaded assembly workbench, then the command Assembly_LinkSelectLinked is not loaded yet.
Before I guess that in this case cmd was nullptr. But now it is apparantly not null anymore. But now getAction still returns null because the command is not loaded yet.