Skip to content

Assembly: Fix crash on right click assembly link#29887

Merged
maxwxyz merged 1 commit into
FreeCAD:mainfrom
PaddleStroke:patch-795831
May 16, 2026
Merged

Assembly: Fix crash on right click assembly link#29887
maxwxyz merged 1 commit into
FreeCAD:mainfrom
PaddleStroke:patch-795831

Conversation

@PaddleStroke
Copy link
Copy Markdown
Contributor

@PaddleStroke PaddleStroke commented May 6, 2026

Fix #29702

Note before cmd->getAction() never returned null. I think before cmd was null if there was no action.

So what happens is that if you have not loaded assembly workbench, then the command Assembly_LinkSelectLinked is not loaded yet.

Before I guess that in this case cmd was nullptr. But now it is apparantly not null anymore. But now getAction still returns null because the command is not loaded yet.

@github-actions github-actions Bot added the Mod: Assembly Related to the Integrated Assembly Workbench label May 6, 2026
@FEA-eng
Copy link
Copy Markdown
Contributor

FEA-eng commented May 6, 2026

It fixes the right-click crash, but it crashes or shows the errors below if I double-click on the subassembly.

19:18:49  Illegal storage access...
19:18:49  pyException: Traceback (most recent call last):
  File "<string>", line 2, in <module>
<class 'OSError'>: Illegal storage access! Please save your work under a new file name and restart the application!
OS: Windows 11 build 26200
Architecture: x86_64
Version: 1.2.0dev.46725 (Git)
Build date: 2026/05/06 16:16:18
Build type: Release
Branch: pr29887
Hash: 2dc85d867dd4cf5c24277155f202c5d44a15c417
Python 3.11.14, Qt 6.8.3, Coin 4.0.3, Vtk 9.3.0, boost 1_84, Eigen3 3.4.0, PySide 6.8.3
shiboken 6.8.3, xerces-c 3.3.0, IfcOpenShell 0.0.0, OCC 7.8.1
Locale: Polish/Poland (pl_PL) [ OS: Polish/Poland (pl_PL) ]
Stylesheet/Theme/QtStyle: FreeCAD.qss/FreeCAD Light/
Navigation Style/Orbit Style/Rotation Mode: CAD/Rounded Arcball/Window center
Logical DPI/Physical DPI/Pixel Ratio: 96/81.5973/1

@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue May 6, 2026
@maxwxyz maxwxyz added this to the 1.2 milestone May 6, 2026
@maxwxyz maxwxyz added the Type: Bug This issue or PR is related to a bug label May 6, 2026
@PaddleStroke
Copy link
Copy Markdown
Contributor Author

PaddleStroke commented May 7, 2026

it crashes or shows the errors below if I double-click on the subassembly.

This is a different bug. See #29901

Copy link
Copy Markdown
Contributor

@FEA-eng FEA-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwxyz Tested, fixes the right-click crash

@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue May 7, 2026
@maxwxyz maxwxyz added the Approved: Tested The PR was manually tested and approved label May 7, 2026
@maxwxyz maxwxyz merged commit 9be651e into FreeCAD:main May 16, 2026
29 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Merge Queue May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Tested The PR was manually tested and approved Mod: Assembly Related to the Integrated Assembly Workbench Type: Bug This issue or PR is related to a bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Assembly: When right-clicking on sub-assembly item in the tree or deleting in the 3D view crashes in v1.2-dev and works in v1.1.1

3 participants