Skip to content

Gui/PD: Toggle body only from 3D view selection#30231

Merged
kadet1090 merged 1 commit into
FreeCAD:mainfrom
maxwxyz:pd-toggle-space
May 18, 2026
Merged

Gui/PD: Toggle body only from 3D view selection#30231
kadet1090 merged 1 commit into
FreeCAD:mainfrom
maxwxyz:pd-toggle-space

Conversation

@maxwxyz
Copy link
Copy Markdown
Contributor

@maxwxyz maxwxyz commented May 17, 2026

Supersedes #30218
PR #29110 changed that the spacebar always toggled the entire body when selected from the 3D view but that also changed for the space bar when a feature was selected in the tree view. Then, only in an active body, the features were toggled.

This changes the behavior:

There's a scenario where focus isn't reliable, if the user clicks in the tree to select, then clicks somewhere else in the UI without reselecting, then presses Space. This is very unlikely in normal usage.

Issues

Fixes #30216
Fixes #30221

Before and After Images

Bildschirmaufnahme.2026-05-17.um.10.46.21.mov

@maxwxyz maxwxyz added Requires: UI/UX review Issue/PR to be reviewed in terms of UI/UX by the Design Working Group or under refinement. Requires: Testing The PR needs testing by users and developers Requires: Code Review The PR requires code to be reviewed labels May 17, 2026
@maxwxyz maxwxyz added this to the 1.2 milestone May 17, 2026
@github-actions github-actions Bot added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Mod: Part Design Related to the Part Design Workbench labels May 17, 2026
@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue May 17, 2026
@maxwxyz maxwxyz added the Type: Bug This issue or PR is related to a bug label May 17, 2026
@maxwxyz maxwxyz requested a review from FEA-eng May 17, 2026 08:53
@maxwxyz
Copy link
Copy Markdown
Contributor Author

maxwxyz commented May 17, 2026

@leoheck @entuland FYI

@entuland
Copy link
Copy Markdown

The video in the very first post looks good, I assume it's showcasing keyboard interaction.

Unfortunately I'm unable to test the PR before merging (no idea how to even test it, I could barely get the main branch pulled and built with pixi) plus I'm currently cut out from the Internet via my normal connection, forced to connect via USB tethering on a crappy mobile data plan.

If this fix also covers the context menu interaction (not illustrated by the video) retaining the old behavior, it would be functionally sound for me.

Apologies for the limited help I can provide here.

Copy link
Copy Markdown
Contributor

@FEA-eng FEA-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the issues and works as described

@maxwxyz maxwxyz added Approved: Tested The PR was manually tested and approved and removed Requires: Testing The PR needs testing by users and developers labels May 17, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue May 17, 2026
@kadet1090 kadet1090 added Topic: Performance Tickets related to issues with degraded performance speed and smoothness of FreeCAD Approved: Code Quality The PR was checked for code quality and approved Approved: UI/UX The Issue/PR was reviewed in terms of UI/UX and approved by the Design Working Group and removed Requires: Code Review The PR requires code to be reviewed Requires: UI/UX review Issue/PR to be reviewed in terms of UI/UX by the Design Working Group or under refinement. labels May 18, 2026
@kadet1090 kadet1090 enabled auto-merge (rebase) May 18, 2026 12:36
@kadet1090 kadet1090 merged commit 20c0100 into FreeCAD:main May 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Code Quality The PR was checked for code quality and approved Approved: Tested The PR was manually tested and approved Approved: UI/UX The Issue/PR was reviewed in terms of UI/UX and approved by the Design Working Group Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Mod: Part Design Related to the Part Design Workbench Topic: Performance Tickets related to issues with degraded performance speed and smoothness of FreeCAD Type: Bug This issue or PR is related to a bug

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

BUG - Can't see nested Features on More than one Body Arrow navigation is not working in object tree inside the Body.

4 participants