Gui/PD: Toggle body only from 3D view selection#30231
Merged
Merged
Conversation
Contributor
Author
|
The video in the very first post looks good, I assume it's showcasing keyboard interaction. Unfortunately I'm unable to test the PR before merging (no idea how to even test it, I could barely get the main branch pulled and built with pixi) plus I'm currently cut out from the Internet via my normal connection, forced to connect via USB tethering on a crappy mobile data plan. If this fix also covers the context menu interaction (not illustrated by the video) retaining the old behavior, it would be functionally sound for me. Apologies for the limited help I can provide here. |
FEA-eng
approved these changes
May 17, 2026
Contributor
FEA-eng
left a comment
There was a problem hiding this comment.
Tested, fixes the issues and works as described
kadet1090
approved these changes
May 18, 2026
7765bcc to
b23a74e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #30218
PR #29110 changed that the spacebar always toggled the entire body when selected from the 3D view but that also changed for the space bar when a feature was selected in the tree view. Then, only in an active body, the features were toggled.
This changes the behavior:
There's a scenario where focus isn't reliable, if the user clicks in the tree to select, then clicks somewhere else in the UI without reselecting, then presses Space. This is very unlikely in normal usage.
Issues
Fixes #30216
Fixes #30221
Before and After Images
Bildschirmaufnahme.2026-05-17.um.10.46.21.mov