Skip to content

Some optimizations and fixes.#6

Merged
ChadSikorra merged 1 commit intomasterfrom
patch/optimize-read
Apr 25, 2026
Merged

Some optimizations and fixes.#6
ChadSikorra merged 1 commit intomasterfrom
patch/optimize-read

Conversation

@ChadSikorra
Copy link
Copy Markdown
Contributor

A few fixes coming out of some performance profiling in the LDAP repo:

  1. When reading data, don't peek. This eliminates a costly fread when dealing with lots of data.
  2. Update the message queue to correctly use generators for getMessages. Remove the useless generate usage for getMessage.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

❌ Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.19%. Comparing base (df21e77) to head (713dcb0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/FreeDSx/Socket/Socket.php 86.95% 3 Missing ⚠️
src/FreeDSx/Socket/Queue/MessageQueue.php 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
+ Coverage     77.11%   81.19%   +4.07%     
+ Complexity      105      101       -4     
============================================
  Files             7        7              
  Lines           319      319              
============================================
+ Hits            246      259      +13     
+ Misses           73       60      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChadSikorra ChadSikorra force-pushed the patch/optimize-read branch from d44a082 to 6c9ad2d Compare April 25, 2026 12:44
…ing with lots of data.

Update the message queue to correctly use generators for getMessages. Remove the useless generate usage for getMessage.
@ChadSikorra ChadSikorra force-pushed the patch/optimize-read branch from 6c9ad2d to 713dcb0 Compare April 25, 2026 12:51
@ChadSikorra ChadSikorra merged commit 18ce114 into master Apr 25, 2026
24 checks passed
ChadSikorra added a commit that referenced this pull request Apr 25, 2026
* Revert "When reading data, don't peek. This elimates a costly fread when dealing with lots of data. (#6)". This will land in a 1.0 release. Locking deps across all repos with unpinned deps.

This reverts commit 18ce114.

* Lock FreeDSx dependencies to prepare for a 1.0 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant