-
Notifications
You must be signed in to change notification settings - Fork 204
Separate nullspace and nearnullspace, add transposenullspace
#372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM, @echarala, could you please confirm this fixes your issue? |
|
Yes, it should. I will try it in my problem. Nice fix, guys! |
|
@prj- note that the CI pipeline didn’t auto-run for this PR yet. It passes |
|
Yeah, there is no reason to have it fail |
|
While this is in the works, should I also add an interface to |
nullspace and nearnullspacenullspace and nearnullspace, add transposenullspace
|
Would you be OK with me merging this, @cmdoug? |
|
Sure thing. Will do some work on the PETSc side next couple weeks and start a new one for the remaining stuff. |
|
Sounds good, thanks! |
Attempt to fix #371 reported by @echarala.