Skip to content

Test for a bug in pack_string() (see pull request #13) #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oroulet merged 1 commit into from
Jul 15, 2015
Merged

Test for a bug in pack_string() (see pull request #13) #15

oroulet merged 1 commit into from
Jul 15, 2015

Conversation

@alkor
Copy link
Contributor

@alkor alkor commented Jul 13, 2015

This is a small test for a bug fixed in #13.

If you try to revert #13 and then run tests, you will get the following error:

======================================================================
FAIL: test_unicode_string_nodeid (__main__.Unit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 150, in test_unicode_string_nodeid
    self.assertEqual(new_nid, nid)
AssertionError: NodeId(ns=1;s=hëll) != NodeId(ns=1;s=hëllò)
----------------------------------------------------------------------

Note that the last letter of the node name is lost due to wrong length in the binary packet.

@alkor alkor force-pushed the fix-string-length-test branch from 804b9bb to cc3698f Compare July 13, 2015 12:38
@alkor alkor mentioned this pull request Jul 15, 2015
Merged
oroulet added a commit that referenced this pull request Jul 15, 2015
@oroulet
Merge pull request #15 from alkor/fix-string-length-test
817f5d0 
Test for a bug in pack_string() (see pull request #13)
@oroulet oroulet merged commit 817f5d0 into FreeOpcUa:master Jul 15, 2015
@alkor alkor deleted the fix-string-length-test branch July 15, 2015 14:03
JensPfeifle pushed a commit to JensPfeifle/python-opcua that referenced this pull request Dec 16, 2020
@helmut-jacob
Merged in speed_up_trigger_event_ilabs (pull request FreeOpcUa#15)
9ed8375 
Reuse the same Variant(None) on emitting events for non-existant fields

Approved-by: Jens Pfeifle <jens.pfeifle@rommelag.com>
Approved-by: Andreas Monsch <andreas.monsch@rommelag.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alkor @oroulet