[bug]: Reccurent Events do not work with local Calendar

[julien-celya]

FreePBX Version

FreePBX 16

Issue Description

Hi,
Here is the configuration I used :

• a local calendar that some users can access and modify
• added a recurring event ( 8am to 5pm, recurring 4 times ) with a category
• a calendar event group that match for previous category
• a time condition that checks the calendar event group

The time condition does not match (at the very least during a recurring event)

Hunting down the bug, it appears to be in the Calendar module, either in IcalParser/IcalRangedParser.php or in the handling of recurring event for a local calendar.

In IcalParser/IcalRangedParser.php, getEventsNow([...]) expects $event['RECURRENCES'] to be timestamps when they are objects :

[...]
["RECURRENCES"]=>                
      array(4) {                       
        [0]=>                          
        object(DateTime)#55 (3) {      
          ["date"]=>                   
          string(26) "2025-04-22 12:30:00.000000"
          ["timezone_type"]=>          
          int(3)                       
          ["timezone"]=>               
          string(12) "Europe/Paris"    
        }
[...]

Working fix for the Calendar module :

diff --git a/IcalParser/IcalRangedParser.php b/IcalParser/IcalRangedParser.php
index 704d156..47b964b 100644
--- a/IcalParser/IcalRangedParser.php
+++ b/IcalParser/IcalRangedParser.php
@@ -366,7 +366,7 @@ class IcalRangedParser extends IcalParser
 					$eventDuration = $event['DTEND']->getTimestamp() - $event['DTSTART']->getTimestamp();
 
 					foreach ($recurrences as $recurrenceTimestamp) {
-						if ($now > $recurrenceTimestamp && $now < ($recurrenceTimestamp + $eventDuration)) {
+						if ($now > $recurrenceTimestamp->getTimestamp() && $now < ($recurrenceTimestamp->getTimestamp() + $eventDuration)) {
 							array_push($events, $event); //at least one recurrence is now, keep it
 							continue 2; //go to the next event
 						}

Regards,

Operating Environment

Debian 12
asterisk 20.11.1
calendar | 16.0.34
core | 16.0.68.30
framework | 16.0.40.11
timeconditions | 16.0.11

Relevant log output

[julien-celya]

Adding that I'm also reproducing the issue with a remote iCal and CalDAV on another system => it is not a problem with local calendars.

[kapilgupta01]

pushed fix to the edge release. thanks

[voggur]

This update "17.0.4.21" broke "Calendar Event Groups" matching downgrading to "17.0.4.20" fixed my problem.

[kapilgupta01]

thanks @voggur for the prompt update, i will revert back the fix from the edge release.

[kapilgupta01]

Hi @julien-celya just fyi - reverted your latest commit from the release branch due to #717

however your fix is still part of 17.0.4.21 release if you like to re-check about the issue.

thanks

[julien-celya]

Hi @kguptasangoma & @voggur,
I admit that I only tried out my fix in a v16 environment.
I'll re-check it in v17.

[julien-celya]

@voggur : can you confirm if the problems you had were using an outlook calendar ?

My tests in v17 with 17.0.4.21 :

• local and ical calendars have no problem (normal or recurring events, calendar or calendar group)
• caldav calendar fails everytime in the agi (normal or recurring, calendar or calendar group, also with module v17.0.4.20)

[julien-celya]

Hi

With additional logs in IcalParser/IcalRangedParser.php, I'm noticing that one variable is not always of the same type :
$recurrenceTimestamp is either an integer (unix timestamp) or a DateTime.

[2026-04-30 10:58:02] [calendarReccurrentEvtsDebug.DEBUG]: var {"$now":1777539482,"$recurrenceTimestamp":"2026-04-30 07:00:00","$duration":46800} []
[2026-04-30 10:58:02] [calendarReccurrentEvtsDebug.DEBUG]: var type {"gettype($now)":"integer","gettype($recurrenceTimestamp)":"object","gettype($duration)":"integer"} []
[2026-04-30 10:58:02] [calendarReccurrentEvtsDebug.DEBUG]: CLASS OF $recurrenceTimestamp ["DateTime"] []

[2026-04-30 10:58:02] [calendarReccurrentEvtsDebug.DEBUG]: var {"$now":1777539482,"$recurrenceTimestamp":1777525200,"$duration":48600} []
[2026-04-30 10:58:02] [calendarReccurrentEvtsDebug.DEBUG]: var type {"gettype($now)":"integer","gettype($recurrenceTimestamp)":"integer","gettype($duration)":"integer"} []

In the case $recurrenceTimestamp is a DateTime, the tests fail (comparing an integer and a DateTime throws an Exception, as does adding an integer to a DateTime).

For reference, I tested :

• local calendards : $recurrenceTimestamp is always a DateTime
• nextcloud iCal : $recurrenceTimestamp is always a DateTime
• nextcloud caldav : $recurrenceTimestamp is always a DateTime
• google iCal : $recurrenceTimestamp is an integer (unix timestamp) in at least one case

I'm going to submit a new patch to convert $recurrenceTimestamp if it is a DateTime

Regards