[bug]: User manager fails to load after restoral from backup if there is an AD connected to the system

[googleuser3212]

FreePBX Version

FreePBX 17

Issue Description

I have experienced an error where if in the backup file there was an active directory connection in userman, and I restored from that backup, it would cause an error with userman and contact manager, causing me to have to go in and comment out lines in the code to make it work again. I don't have screenshots of it since I haven't had to go through the restoral process in a while (knock on wood).

Operating Environment

Asterisk 22, Freepbx 17, Debian 12, Active Directory primary running on Windows Server 2022

Relevant log output

[googleuser3212]

I am going to try to replicate the error right now and I will post more info here

[googleuser3212]

So this is the error that I get when trying to log in after a restore that contains an AD directory

Syntax error on line 317 of file /var/www/html/admin/modules/userman/functions.inc/auth/Auth.php

and my solution is to go in and comment it out

[googleuser3212]

I am going to go grab what is on line 317. I am also going to restore to the other backup I made that doesn't have the AD settings in it.

[googleuser3212]

This is the line in auth.php that causes the issue:

			$group['users'] = isset($group['users']) ? json_decode((string) $group['users'],true, 512, JSON_THROW_ON_ERROR) : NULL;

Here is the rest of the code that it is nested in:

	public function getAllGroups() {
		if(!empty($this->config['id'])) {
			$sql = "SELECT * FROM ".$this->groupTable." WHERE auth = :auth ORDER BY priority";
			$sth = $this->db->prepare($sql);
			$sth->execute([":auth" => $this->config['id']]);
		} else {
			$sql = "SELECT * FROM ".$this->groupTable." ORDER BY priority";
			$sth = $this->db->prepare($sql);
			$sth->execute();
		}
		$groups = $sth->fetchAll(PDO::FETCH_ASSOC);
		foreach($groups as &$group) {
			$group['users'] = isset($group['users']) ? json_decode((string) $group['users'],true, 512, JSON_THROW_ON_ERROR) : NULL;
			$group['users'] = is_array($group['users']) ? $group['users'] : [];
		}
		return $groups;
	}