[core] fix freerdp_get_nla_sspi_error always returning 0 on client#12574
Merged
akallabeth merged 1 commit intoApr 8, 2026
Merged
Conversation
|
Can one of the admins verify this patch? |
Member
|
@freerdp-bot test |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
freerdp_get_nla_sspi_errorreturns 0 or accesses a null pointer on client-side connections.The function retrieves the NLA pointer via
transport_get_nla(), which returnstransport->nla. This pointer is only populated on the server side (transport_accept_nla). On the client side, NLA lives onrdp->nla(created intransport_connect_nla), andtransport->nlaisNULLcausing the assert innla_get_sspi_errorto fire or returning 0.Instead, se
rdp->nlafirst with a fallback totransport_get_nla(), matching the pattern already used by other NLA wrapper functions in the same file. This makes the function work correctly for both client (rdp->nla) and server (transport->nla) callers (although utility on the server side is questionable).