[Cellular Library] Add ci.yml for unit-test#26
Merged
andysun2015 merged 18 commits intoFreeRTOS:mainfrom Aug 17, 2021
Merged
Conversation
andysun2015
force-pushed
the
cellular_add_workflow
branch
from
94a3113 to
b33a641
Compare
[Cellular Library] changes for MISRA C in common/src/cellular_pktio.c * Fix the misra c Event misra_c_2012_rule_10_8_violation and misra_c_2012_rule_8_13_violation [Cellular Library] changes for MISRA C in common/src/cellular_pkthandler.c 1. Misra C changes for Event misra_c_2012_rule_10_8_violation and Event misra_c_2012_rule_8_13_violation [Cellular Library Unit-Test] Remove testing configuration. [Cellular Library] changes for MISRA C in common/src/cellular_common.c [Cellular Library] remove one condition that never happened in common/src/cellular_at_core.c Revert "[Cellular Library Unit-Test] Add ut code for cellular_3gpp_api.c" This reverts commit ffe9ebe7b12ac902c559eebca9cf51aebda17f1b. [Cellular Lib] Adjustment for coverity. [Cellular Lib] changes for coverity [Cellular Lib] format code and add misra configuration file. [Cellular Lib] Fix unit test coverage caused by CBMC changes. [Cellular Lib] Changes for misra c [Cellular Lib]Fix misra_c_2012_rule_1_1_violation from opaque data type. [Cellular Lib] Fix build warning from pointer-to-int-cast warnings.
[Cellular Library] changes for the full coverage in cellular_pktio.c [Cellular Library] changes for the full coverage in cellular_at_core_utest.c [Cellular Library] changes for the full coverage in cellular_pkthandler_utest.c [Cellular Library] changes for the full coverage in cellular_common_api_utest.c [Cellular Library] changes for the full coverage in cellular_common_utest.c [Cellular Library] changes for the full coverage in cellular_3gpp_urc_handler_utest.c [Cellular Library] changes for the full coverage in cellular_3gpp_api_utest.c [Cellular Library] Fix build warnings in unit test
andysun2015
force-pushed
the
cellular_add_workflow
branch
from
b33a641 to
ec564ba
Compare
chinglee-iot
reviewed
Aug 9, 2021
…lized variable in unit test.
chinglee-iot
previously approved these changes
Aug 10, 2021
Contributor
chinglee-iot
left a comment
chinglee-iot
left a comment
There was a problem hiding this comment.
Unit test branch coverage 100% and local test the cellular library with cellular demo without problem.
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
approved these changes
Aug 17, 2021
chinglee-iot
approved these changes
Aug 17, 2021
Contributor
chinglee-iot
left a comment
chinglee-iot
left a comment
There was a problem hiding this comment.
This PR is for CI. We agree to fix the error token logic in next PR.
| { | ||
| pTokenSuccessTable = pContext->tokenTable.pCellularSrcTokenSuccessTable; | ||
| tokenSuccessTableSize = pContext->tokenTable.cellularSrcTokenSuccessTableSize; | ||
| pTokenErrorTable = pContext->tokenTable.pCellularSrcTokenErrorTable; |
Contributor
There was a problem hiding this comment.
The original logic is that, if this is error token, it won't be saved as intermediate response.
Suggest we update the logic unless this is a bug fix.
if( result != true )
{
( void ) Cellular_ATcheckErrorCode( pLine, pTokenErrorTable,
tokenErrorTableSize, &result );
if( result == true )
{
pResp->status = false;
pkStatus = CELLULAR_PKT_STATUS_OK;
CellularLogError( "Modem return ERROR: line %s, cmd : %s, respPrefix %s, status: %d",
( pContext->pCurrentCmd != NULL ? pContext->pCurrentCmd : "NULL" ),
pLine,
( pRespPrefix != NULL ? pRespPrefix : "NULL" ),
pkStatus );
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.