[Cellular Library] Align the logging method with the other library.#34
Merged
andysun2015 merged 3 commits intoFreeRTOS:mainfrom Aug 26, 2021
Merged
Conversation
andysun2015
force-pushed
the
cellular_align_logging
branch
from
f1b4887 to
ccd1d9f
Compare
andysun2015
force-pushed
the
cellular_align_logging
branch
from
ccd1d9f to
db00ec7
Compare
| #endif | ||
|
|
||
|
|
||
| #define CellularLogError LogError |
Contributor
There was a problem hiding this comment.
Suggest we use LogError in the code and remove CellularLogError.
The same suggestion for CellularLogWarn, CellularLogInfo, CellularDebug.
Contributor
Author
There was a problem hiding this comment.
That sounds good.
Contributor
Author
There was a problem hiding this comment.
please refer to this commit [Cellular Library] Remove all prefix Cellular in Log functions.
DanielYEHsieh
approved these changes
Aug 25, 2021
cobusve
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.