[Cellular Library] Fix build warning message. by andysun2015 · Pull Request #37 · FreeRTOS/FreeRTOS-Cellular-Interface

andysun2015 · 2021-09-01T01:43:12Z

Description of changes:

Fix build warning message.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cobusve · 2021-09-02T15:19:16Z

    CellularContext_t context;
    CellularCommInterface_t * pCommIntf = &CellularCommInterface;
-    CellularCommInterfaceHandle_t commInterfaceHandle;
+    CellularCommInterfaceHandle_t commInterfaceHandle = ( CellularCommInterfaceHandle_t ) malloc( sizeof( CellularCommInterfaceHandle_t ) );


malloc fails?

please refer to this change.

cobusve · 2021-09-02T15:47:01Z

@@ -903,11 +903,10 @@ void test_Cellular_ATStrtoi_Happy_Path( void )
 {
    CellularATError_t cellularStatus = CELLULAR_AT_SUCCESS;
    char * pStr = malloc( sizeof( char ) * ( strlen( CELLULAR_SAMPLE_STRTOL_HAPPY_CASE_STRING ) + 1 ) );


please refer to this change.

cobusve · 2021-09-03T15:26:12Z

        {
            *ppAtResp = _Cellular_AtResponseNew();
-            LogDebug( ( "Allocat at response %p", *ppAtResp ) );
+            LogDebug( ( "Allocat at response %p", ( void * ) *ppAtResp ) );


Spelling error

Thanks for the correction.

Please refer to this change for the correction.

andysun2015 added 2 commits September 1, 2021 09:36

[Cellular Library] Fix build warning message in unit test

804c8dd

[Cellular Library] Correct memory estimation.

b5c3a17

andysun2015 requested a review from chinglee-iot September 1, 2021 01:44

chinglee-iot previously approved these changes Sep 1, 2021

View reviewed changes

Comment thread docs/doxygen/pages.dox

Comment thread include/cellular_config_defaults.h