Event Groups: snapshot xEventGroupSetBits returning value while in vTaskSuspendAll #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…askSuspendAll. Fixes uxEventBits dereference after event group deleted by higher priority thread.
Contributor
Author
|
@aggarg Do I need to contribute unit tests to https://github.com/FreeRTOS/FreeRTOS first? |
aggarg
reviewed
Sep 11, 2024
Member
|
Please merge main to fix the CI failure. |
Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com>
|
aggarg
approved these changes
Sep 11, 2024
kar-rahul-aws
approved these changes
Sep 11, 2024
moninom1
pushed a commit
to moninom1/FreeRTOS-Kernel
that referenced
this pull request
Sep 30, 2025
* Exclude examples in FreeRTOS-Kernel from build * Update vega and microsemi risc-v eclipse project * Update polarfire eclipse project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event Groups: snapshot xEventGroupSetBits returning value while in vTaskSuspendAll
Description
Event Groups: snapshot xEventGroupSetBits returning value while in vTaskSuspendAll.
Fixes uxEventBits dereference after event group deleted by higher priority thread.
Test Steps
Code example that causes issues: https://github.com/flipperdevices/flipperzero-firmware/blob/78c5dd95d867941206e1be2fd3585c9c76132bd7/furi/core/timer.c#L43
General flow to reproduce issue:
Previously return results was not guaranteed because High Priority Thread deleted EventGroup before uxEventBits dereference.
In this PR result will be as described in documentation.
Checklist:
Related Issue
#1142
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.