Task: fix compiler warning for architectures that does not define portARMV8M_MINOR_VERSION #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tARMV8M_MINOR_VERSION
aggarg
approved these changes
Sep 11, 2024
Member
|
Please merge the main to fix the CI check failure. |
urutva
approved these changes
Sep 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: fix compiler warning for architectures that does not define portARMV8M_MINOR_VERSION
Description
task.h was using
#ifon macros that was not used in some architectures.This fix explicitly checks if macros defined and only then compares it with value.
Test Steps
Compile with -Werror=undef
Checklist:
Related Issue
None
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.