Fix risk of Win32 timer setup call getting ignored #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not sure how to run tests - please let me know if I should do anything in that regard. |
If a user configures the configASSERT macro to expand to nothing, a call to the Win32 API SetWaitableTimer() doesn't get compiled. This can happen if, for example, configASSERT(x) set defined as assert(x) (from assert.h) which expands to nothing when NDEBUG is set (common for "release" builds).
kschwan
force-pushed
the
fix-win32-timer-setup-release-builds
branch
from
63fd5e9 to
2d7e22f
Compare
|
aggarg
approved these changes
Aug 15, 2025
xuelix
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user configures the
configASSERTmacro to expand to nothing, a call to the Win32 APISetWaitableTimer()doesn't get compiled.This can happen if, for example,
configASSERTset defined asassert(from assert.h) which expands to nothing whenNDEBUGis set (common for "release" builds).This PR has a patch to fix the issue.
Test Steps
Using the Win32 port, define
configASSERTas follows:then the scheduler doesn't "tick" and calls to, fx.,
vTaskDelay()won't return.Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.