Style: Make Renesas RXv3 DPFPU port layer consistent with uncrustify. #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following changes are made.
Add '/* *INDENT-OFF* */' and '/* *INDENT-ON* */' around inline assembly code in C source files.
Add above comments around '#ifdef __cplusplus extern "C" #endif' in portmacro.h.
Add above comments around '#ifdef __cplusplus } #endif' in portmacro.h.
Add '; /* *INDENT-OFF* */' at the top of assembly source file.
Remove '1 tab == 4 spaces!'.
Change tab to spaces.
Beautification by uncrustify.
Beautification by hand (no conflict with uncrustify).
Fix inconsistency which I didn't notice at the commit 386d854: DFPU --> DPFPU.
The following uncrustify and config file are used.
uncrustify: uncrustify-0.71.0_f-win32
config: FreeRTOS/tools/uncrustify.cfg
Test Steps
There are no changes in the MOT and SREC files (the following total 2 * 3 * 3 = 18 cases) which are built for Renesas RX72N Envision Kit RTOS Demo between before and after.
Total 2 * 3 * 3 = 18 cases:
(1) Define/not define USE_FULL_REGISTER_INITIALISATION in FreeRTOSConfig.h
(2) Define configUSE_TASK_DPFPU_SUPPORT = 1, 2, 0 in FreeRTOSConfig.h
(3) GNURX, CC-RX, ICCRX
Related Issue
Style: Revert uncrustify for portable directories #115
#115 (comment)
In addition to a small tip in the above conversation for embedding /* *INDENT-OFF* */ into Renesas CC-RX's assembly source file (*.src), I notice that there is another tip to do it. The following source file is fortunately consistent with uncrustify. But I'm not sure whether it may cause some other problems or not.
Especially there are two spaces between ';' and '*', for example:
instead of one space between ';' and '*', for example:
It may happen that two spaces will be re-formatted to one space by other tool or script.
FreeRTOS/Source/portable/Renesas/RX700v3_DPFPU/port_asm.src
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.