-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Style: Revert uncrustify for portable directories #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Will uncrustify be executed in the future again? If so, how do you separate source files into the following two groups? Manually? or by something like shell script? GROUP-A) Execute uncrustify Or... (if necessary,) will we have to use the following comments in all source files? (This is a question, not a disagreement.) /* *INDENT-OFF* */ Renesas CC-RX's assembly source file (such as *.src) cannot accept such comments which do not start with ';'. On the other hand, IAR ICCRL78 assembly source file (such as *.s87) can accept such C-style comments at least the latest version of EWRL78. [Added] I notice a tip to embed such comments into Renesas CC-RX's assembly source file (*.src). Using conditioal assemble statement .IF ~ .ENDIF makes it possible as follows. (But I notice just now that *.src files are excluded from 'Style: Uncrustify' target files.) FreeRTOS/Source/portable/Renesas/X600v2/prt_asm.src (Moreover this file doesn't need uncrustify.) |
|
Hi @NoMaY-jp We will be using a github script hook to seprarate both groups, we will eventually uncrustify all the files |
|
Or... (if necessary,) will we have to use the following comments in all source files? (This is a question, not a disagreement.) /* INDENT-OFF / we still have to use these around some assembly instructions, as uncrustify can't detect all ASM uses, and is trying to format them |
Revert uncrustify for untested portable directories
Description
Uncrustify messed up some inline assembly for some compilers
We are reverting some compiler directories inside portable
Test Steps
already changed folders/files after previous uncrustify
Related Issue
90, 91, 107, 111
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.