Feature: SMP #278
Merged
Feature: SMP #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor modifications are also made to the kernel to support the XCore compiler's automatic stack size calculation.
The XMOS XCore ports are also updated to support SMP.
The port set and clear interrupt mask from ISR macros were removed from the ports so that the default macros found in FreeRTOS.h are used instead. The default macros do not result in warnings when they are used.
* feature/xcore: Fix compiler warnings in xcore ports
Inline function converted to macro. This should now build when optimizations are off and inlining is disabled.
* feature/xcore: Remove inline function from timers.h
* main: Add some assertions and coverage exceptions to queue.c (#273) Moved git-secrets check to a different workflow (#271) Comment: fix code comment for xTaskAbortDelay (#272) Added git-secrets check to Github Actions (#270) fixed documentation for ulTaskNotifyTake() and ulTaskNotifyTakeIndexed() (#269) Add description for vTaskList (#206) Support allocating stack from separate heap (#267) Update python version to 3.7.10 (#265) Update URL in history.txt (#259) Remove unmatched braces in MessageBuffer pre tags (#256) Check: improve verbosity of url verifier (#260) Update issue templates incorporate updates from common (#255) Typos (#248) Delete gitattributes (#253) Fix typo in comment in task.h (#244) Fix Github checks after move from master to main (#246)
* feature/xcore: Add some assertions and coverage exceptions to queue.c (#273) Moved git-secrets check to a different workflow (#271) Comment: fix code comment for xTaskAbortDelay (#272) Added git-secrets check to Github Actions (#270) fixed documentation for ulTaskNotifyTake() and ulTaskNotifyTakeIndexed() (#269) Add description for vTaskList (#206) Support allocating stack from separate heap (#267) Update python version to 3.7.10 (#265) Update URL in history.txt (#259) Remove unmatched braces in MessageBuffer pre tags (#256) Check: improve verbosity of url verifier (#260) Update issue templates incorporate updates from common (#255) Typos (#248) Delete gitattributes (#253) Fix typo in comment in task.h (#244) Fix Github checks after move from master to main (#246)
Contributor
|
I'm very interested in SMP! But is there a reason why this touches almost every line in every file in the entire repository? #280 then touches everything again. This makes it very hard to work with this branch. |
Member
|
Those were probably (accidental) line ending changes. You can hide white-space changes to make it easier to look. |
|
For feature as big (and interesting) as this, irrelevant files shouldn't be touched so everyone else will understand the changes better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch for developing SMP
Description
This new branch holds the changes needed to support SMP operations for XMOS, TI, Espressif and Raspberry Pi. This feature comes from an XMOS private repo.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.