Skip to content

Conversation

@aggarg
Copy link
Member

@aggarg aggarg commented Oct 17, 2023

Description

The PR #836 addresses a potential integer overflow.

Test Steps

Tested using STM32H743ZI demo project.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aggarg
Copy link
Member Author

aggarg commented Oct 17, 2023

The unit test failures is expected as code has changed and the demo failure is because QEmu demo has been removed.

@aggarg aggarg merged commit 7003ba7 into FreeRTOS:10.6.x Oct 17, 2023
@aggarg aggarg deleted the backport_pr836 branch October 17, 2023 18:19
/**
* @brief Max value that fits in a size_t type.
*/
#define mpuSIZE_MAX ( ~( ( size_t ) 0 ) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider changing this to uint32_t to match the type of parameter 2 in MPU_uxTaskGetSystemStateImpl()

Copy link
Member

@joshzarr joshzarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this matches the equivalent change on mainline.
The comment can be addressed with a follow on change if needed.

DajanaV pushed a commit to auroralabs-loci/FreeRTOS-Kernel that referenced this pull request Dec 3, 2025
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants