Skip to content

Port S3 multi-threaded download demo from C-SDK#436

Merged
sukhmanm merged 12 commits intoFreeRTOS:masterfrom
sukhmanm:demos/port-s3-multithreaded
Dec 4, 2020
Merged

Port S3 multi-threaded download demo from C-SDK#436
sukhmanm merged 12 commits intoFreeRTOS:masterfrom
sukhmanm:demos/port-s3-multithreaded

Conversation

@sukhmanm
Copy link
Contributor

@sukhmanm sukhmanm commented Dec 2, 2020

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sukhmanm sukhmanm requested a review from a team as a code owner December 2, 2020 00:59
@sukhmanm sukhmanm marked this pull request as draft December 2, 2020 01:46
@sukhmanm sukhmanm force-pushed the demos/port-s3-multithreaded branch from b474edc to 647bef3 Compare December 2, 2020 16:54
@sukhmanm sukhmanm marked this pull request as ready for review December 2, 2020 16:57
#define configMAX_PRIORITIES ( 7 )
#define configTICK_RATE_HZ ( 1000 ) /* In this non-real time simulated environment the tick frequency has to be at least a multiple of the Win32 tick frequency, and therefore very slow. */
#define configMINIMAL_STACK_SIZE ( ( unsigned short ) 60 ) /* In this simulated case, the stack only has to hold one small structure as the real stack is part of the Win32 thread. */
#define configTOTAL_HEAP_SIZE ( ( size_t ) ( 2048U * 1024U ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the addition for the heap size? I don't understand the significance of 2k + 1k.

#define configUSE_TIMERS 1
#define configTIMER_TASK_PRIORITY ( configMAX_PRIORITIES - 1 )
#define configTIMER_QUEUE_LENGTH 5
#define configTIMER_TASK_STACK_DEPTH ( configMINIMAL_STACK_SIZE * 2 )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the timer stack depth for this demo 2x the minimum stack size? Is there some science behind the * 2? I would prefer to simply enter the "correct size" for these stack entries. I don't think there is any reason in the demo why the stack needs to be exactly 2x bigger than the minimum.

@sukhmanm sukhmanm merged commit d69c9c0 into FreeRTOS:master Dec 4, 2020
paulbartell pushed a commit to paulbartell/FreeRTOS that referenced this pull request Mar 30, 2023
uncrustify

Co-authored-by: Shreyas Balakrishna <shreyasbharath@users.noreply.github.com>
Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com>
Zangetsu112 pushed a commit to Zangetsu112/FreeRTOS-evpp that referenced this pull request Aug 18, 2025
Adding demo to demonstrate the use of pre-signed URLs to connect and download from a S3 bucket. Sends multiple GET requests synchronously to download a file in chunks using range headers. Uses a request and response task in addition to the main HTTP servicing task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants