Create SMP on target test framework. by ActoryOu · Pull Request #911 · FreeRTOS/FreeRTOS

ActoryOu · 2023-01-11T03:02:42Z

Create SMP on target test framework.

Description

Create SMP on target test framework. Including test folders, CMakeLists.txt, template, and first test case.

Test Steps

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

FreeRTOS/Test/Target/tests/smp/template/README.md

FreeRTOS/Test/Target/tests/smp/template/test_name.c

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c

FreeRTOS/Test/Target/boards/pico/tests/smp/multiple_tasks_running/main.c

FreeRTOS/Test/Target/boards/pico/FreeRTOSConfig.h

Dazza0

@ActoryOu Thanks for implementing this, this looks very promising. I've left a few comments/questions based on our past experience of integrating the unity test framework into a CI pipeline in ESP-IDF.

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/test_config.h

FreeRTOS/Test/Target/tests/smp/template/test_name.c

…ActoryOu/FreeRTOS into kernel-on-target-test-framework

Dazza0 · 2023-02-21T06:23:44Z

@ActoryOu Thanks for the explanations. This PR LGTM.

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/test_config.h

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c

chinglee-iot

Some questions want to discuss with you:

Can this test detect the problem that the port fails to launch cores other than tick core?
The EverRunning tasks do nothing but busy looping. How can we know this test function is run by other cores?

ActoryOu · 2023-02-24T08:00:58Z

Can this test detect the problem that the port fails to launch cores other than tick core?

Yes, I think so. If the core fail to be launched, it won't be able to set pxCurrentTCBs[ coreID ] correctly. So the state of task is
NOT eRunning. Furthermore, There is a test case named "Schedule Affinity", it checks if all tasks running on their own cores. We can verify the SMP by combining these two test cases.

The EverRunning tasks do nothing but busy looping. How can we know this test function is run by other cores?

We check the if the state is eRunning, which means it's running at the same time on the other cores. We don't really care about what core is the tasks running on. We just check if all tasks created by the test cases are all in eRunning on all other cores.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>

* update the freertos + TCP demos to use the neew API for getting the UDP pyaload buffer [FreeRTOS_GetUDPPayloadBuffer_ByIPType] (#938) * Add CBMC proof-running GitHub Action (#924) * Added two config options to the FreeRTOSConfig file to get the demo running again. Fixed a typo in a file. Added a section to the link file (#940) * Create SMP on target test framework. (#911) * Fix CBMC proof failures (#946) These were introduced in PR #620. * Make static IP address configurable (#947) * Fix issues in TCP QEMU Demo (#948)

* Add proof for vReceiveRA_ReadReply * Add proof for vReceiveRA * Update test case * Use safeMalloc * Umpdate pxGetNetworkBufferWithDescriptor * Add unit test case for zero prefix option length * Remove unsued parameters

* Framework initialization. * Move testRunner.c to test case subfolder. * Update README doc and formatting. * Add default configurations in test_config.h. * Fix License & formatting check. * Fix typo. * Move setup/teardown functions to main.c file. * Move setup/teardown functions back. * Update README doc. * Patch for comments. * Correct test runner file name. * Move test_config.h to the end of FreeRTOSConfig.h. * Add undef in test_config.h and description in README doc. * Correct the file format. * Fix chinglee-iot comments. * Code review suggestions Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> * Fix spell check Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> --------- Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> Co-authored-by: Gaurav Aggarwal <aggarg@amazon.com>

ActoryOu added 3 commits January 10, 2023 18:02

Framework initialization.

eb6d1bd

Move testRunner.c to test case subfolder.

0cd6985

Update README doc and formatting.

065d4ae

ActoryOu requested a review from a team as a code owner January 11, 2023 03:02

ActoryOu requested a review from aggarg January 11, 2023 03:02

Add default configurations in test_config.h.

d4a46ff

ActoryOu force-pushed the kernel-on-target-test-framework branch from 62724b2 to 74e4e07 Compare January 11, 2023 03:37

Fix License & formatting check.

d983564

ActoryOu force-pushed the kernel-on-target-test-framework branch from 74e4e07 to d983564 Compare January 11, 2023 03:40

ActoryOu added 4 commits January 11, 2023 12:09

Fix typo.

85b5ef9

Move setup/teardown functions to main.c file.

c56c5a8

Move setup/teardown functions back.

f88a383

Update README doc.

07c0e89

aggarg reviewed Jan 12, 2023

View reviewed changes

Patch for comments.

16af1ba

ActoryOu requested a review from aggarg January 30, 2023 09:07

ActoryOu added 2 commits February 3, 2023 11:10

Merge branch 'FreeRTOS:main' into kernel-on-target-test-framework

1e15bf8

Merge branch 'FreeRTOS:main' into kernel-on-target-test-framework

5c249c0

Dazza0 reviewed Feb 17, 2023

View reviewed changes

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/test_config.h Outdated Show resolved Hide resolved

FreeRTOS/Test/Target/tests/smp/template/test_name.c Show resolved Hide resolved

FreeRTOS/Test/Target/tests/smp/template/test_name.c Show resolved Hide resolved

ActoryOu added 2 commits February 20, 2023 11:17

Correct test runner file name.

6f9fb66

Merge branch 'kernel-on-target-test-framework' of https://github.com/…

288b926

…ActoryOu/FreeRTOS into kernel-on-target-test-framework

ActoryOu added 3 commits February 22, 2023 17:46

Move test_config.h to the end of FreeRTOSConfig.h.

185a389

Add undef in test_config.h and description in README doc.

0f8ccb6

Correct the file format.

9105ea1

chinglee-iot reviewed Feb 22, 2023

View reviewed changes

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c Outdated Show resolved Hide resolved

chinglee-iot reviewed Feb 22, 2023

View reviewed changes

FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c Show resolved Hide resolved

Fix chinglee-iot comments.

c92d1b3

ActoryOu requested a review from chinglee-iot February 23, 2023 09:18

chinglee-iot reviewed Feb 24, 2023

View reviewed changes

chinglee-iot previously approved these changes Feb 24, 2023

View reviewed changes

Code review suggestions

f7583b5

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>

aggarg dismissed chinglee-iot’s stale review via f7583b5 March 6, 2023 05:26

aggarg previously approved these changes Mar 6, 2023

View reviewed changes

chinglee-iot self-requested a review March 6, 2023 05:31

chinglee-iot previously approved these changes Mar 6, 2023

View reviewed changes

Fix spell check

1f9f7c8

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>

aggarg dismissed stale reviews from chinglee-iot and themself via 1f9f7c8 March 6, 2023 06:07

aggarg approved these changes Mar 6, 2023

View reviewed changes

chinglee-iot approved these changes Mar 6, 2023

View reviewed changes

aggarg merged commit 67911f8 into FreeRTOS:main Mar 6, 2023

ActoryOu deleted the kernel-on-target-test-framework branch March 7, 2023 01:26

moninom1 mentioned this pull request Mar 7, 2023

Merge main to devIPv6 #953

Merged

Conversation

ActoryOu commented Jan 11, 2023

Description

Test Steps

Related Issue

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dazza0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dazza0 commented Feb 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chinglee-iot left a comment

Choose a reason for hiding this comment

Uh oh!

ActoryOu commented Feb 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants