timer: prevent infinite loop on one-shot timer start #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One-shot timers that expire after a single tick could immediately transition to a dormant state, despite xTimerCommandSent being pdTRUE. This situation resulted in a potential deadlock due to an infinite loop in the timer activation process. Signed-off-by: wangfei_chen <wangfei_chen@realsil.com.cn>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
approved these changes
Feb 24, 2025
kar-rahul-aws
approved these changes
Feb 24, 2025
kar-rahul-aws
changed the title
|
missing ; in FreeRTOS_POSIX_timer.c line 279 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-shot timers that expire after a single tick could immediately transition to a dormant state, despite xTimerCommandSent being pdTRUE. This situation resulted in a potential deadlock due to an infinite loop in the timer activation process.
Issue #, if available:
Fix a potential dead loop issue with One-shot timers that expire after one tick. If such a timer expires immediately, its state becomes dormant while xTimerCommandSent remains pdTRUE, causing a dead loop.
Description of changes:
This commit adds a check to ensure the timer callback count (uxTimerCallbacked) is zero before proceeding, preventing the dead loop.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.