Skip to content

Conversation

@feliperodri
Copy link
Contributor

@feliperodri feliperodri commented Mar 30, 2023

Description

Restructure function contracts for readability.

Test Steps

All CBMC harnesses should continue to pass. No fundamental changes are being applied.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

None.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@feliperodri feliperodri force-pushed the update-function-contracts branch 5 times, most recently from 84193c9 to a95faa6 Compare April 6, 2023 20:54
@feliperodri feliperodri force-pushed the update-function-contracts branch 2 times, most recently from 4660d67 to 8b92dc5 Compare April 7, 2023 04:04
@feliperodri feliperodri marked this pull request as ready for review April 7, 2023 04:04
@feliperodri feliperodri requested a review from a team as a code owner April 7, 2023 04:05
@feliperodri feliperodri force-pushed the update-function-contracts branch 4 times, most recently from 2857b79 to d859f3b Compare April 13, 2023 22:27
@feliperodri feliperodri force-pushed the update-function-contracts branch from d859f3b to 2e5b790 Compare April 20, 2023 03:52
@feliperodri feliperodri force-pushed the update-function-contracts branch 2 times, most recently from 0225979 to 913afaf Compare April 20, 2023 04:02
@n9wxu
Copy link

n9wxu commented Apr 28, 2023

I am trying to verify this PR. The proofs that include cadical are complaining of a command not found. What should be the new CBMC instructions for adding cadical?

n9wxu
n9wxu previously approved these changes Apr 28, 2023
archigup
archigup previously approved these changes May 1, 2023
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri dismissed stale reviews from archigup and n9wxu via cf8ed2a May 4, 2023 17:24
@feliperodri feliperodri force-pushed the update-function-contracts branch from 4966ad0 to cf8ed2a Compare May 4, 2023 17:24
@feliperodri feliperodri requested review from archigup and n9wxu May 5, 2023 14:08
@feliperodri
Copy link
Contributor Author

@n9wxu @archigup could you take one more look?

@n9wxu n9wxu merged commit 8d216b5 into FreeRTOS:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants