Add a const qualified version of search #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgsong
reviewed
Nov 21, 2020
| * @param[in] query The object keys and array indexes to search for. | ||
| * @param[in] queryLength Length of the key. | ||
| * @param[out] outValue A pointer to receive the address of the value found. | ||
| * @param[out] outValue A pointer to receive the index of the value found. |
There was a problem hiding this comment.
Maybe call it outOffset or outValueOffset?
Contributor
Author
There was a problem hiding this comment.
There's already something of a convention that a size_t value or outValue is an index. I don't want to make sweeping changes for only a negligible benefit.
tgsong
reviewed
Nov 21, 2020
| JSONTypes_t * outType ) | ||
| { | ||
| JSONStatus_t ret; | ||
| size_t value; |
Contributor
Author
There was a problem hiding this comment.
See prior comment.
tgsong
reviewed
Nov 21, 2020
source/include/core_json.h
Outdated
| * @param[out] outType An enum indicating the JSON-specific type of the value. | ||
| */ | ||
| /* @[declare_json_searchtc] */ | ||
| JSONStatus_t JSON_SearchTc( const char * buf, |
There was a problem hiding this comment.
There's a JSON_Search API, maybe add another JSON_SearchConst?
tgsong
approved these changes
Nov 22, 2020
cobusve
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior attempts to have the search function accept a const buffer and populate a non-const output pointer were problematic, generating MISRA violations. I settled for having the search function use non-const for both. This PR adds a variation of the search function that accepts a const buffer and populates a const output pointer.