Fix the theming of the share menu logos for the system, black and dracula themes#2330
Merged
PrestonN merged 1 commit intoFreeTubeApp:v0.17.0-RCfrom Jun 20, 2022
Merged
Conversation
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
absidue
added
the
PR: waiting for review
PikachuEXE
previously approved these changes
Jun 17, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 19, 2022
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and PikachuEXE
The base branch was changed.
absidue
requested review from
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 19, 2022
auto-merge was automatically disabled
June 19, 2022 19:34
Pull request was closed
github-actions
bot
removed
the
PR: waiting for review
absidue
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Jun 19, 2022
PikachuEXE
approved these changes
Jun 20, 2022
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the theming of the share menu logos for the system, black and dracula themes (RC branch)
Pull Request Type
Description
This pull request fixes the YouTube and Invidious logos being invisible in the share menu when the system, black or dracula themes are active.
Screenshots (if appropriate)
System
Black
Dracula
Testing (for code that is not small enough to be easily understandable)
I tested this pull request by changing the theme and checking that the logos are visible regardless of the selected theme.
Desktop (please complete the following information):