Fix removing the meta files when navigating to a new video#2345
Merged
PrestonN merged 1 commit intoFreeTubeApp:v0.17.0-RCfrom Jun 21, 2022
Merged
Fix removing the meta files when navigating to a new video#2345PrestonN merged 1 commit intoFreeTubeApp:v0.17.0-RCfrom
PrestonN merged 1 commit intoFreeTubeApp:v0.17.0-RCfrom
Conversation
absidue
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 20, 2022
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Seems to be fixed now, lgtm!
PikachuEXE
approved these changes
Jun 21, 2022
ChunkyProgrammer
approved these changes
Jun 21, 2022
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix removing the meta files when navigating to a new video (RC branch)
Pull Request Type
Related issue
closes #1562
Description
If you are watching a video and go to the next video the videoId property on the component (
this.videoId) changes before the ipc call for the userdata directory returns, so previously that would mean that the old dash and storyboard files wouldn't get deleted and potentially also deleting the ones for the new video, if they are already created at that point. This pull request changes it so that the videoId value is passed in as a function parameter, this means that it isn't affected bythis.videoIdchanging while the function is running asyncronously.This pull request also removes the redundant existence checks for the directories as the file existence check already covers that.
Testing (for code that is not small enough to be easily understandable)
Watch a video and then click a video in the recommended list or open a playlist and go to the next video, the dash and storyboards for the previous video should be deleted.
Desktop (please complete the following information):