Skip to content

Conversation

@ozrendev
Copy link
Contributor

@ozrendev ozrendev commented Feb 28, 2025

Fix: Utilize empty space for playlist queue when Hide Recommended Videos is enabled

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #6925

Description

Playlist area is expanded the entire height of the sidebar when recommended videos are disabled and viewport is wide enough.

Screenshots

Before:
2025-02-28_18-19-34

After:
2025-02-28_18-09-05

Additional context

Unsure if modifying the main viewport height or using @media selectors is the best way to go about this, but it's what I came up with and seems okay when tested with different viewport sizes.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 28, 2025 23:21
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 28, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc

To me areas not lining up is visually displeasing. Would prefer to see #6925 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks the whole layout of the side bar, top bar and settings headers. I can scroll away now

VirtualBoxVM_UfSsZQupHA.mp4

Thumbnail exceeds this line with distraction free setting enabled

VirtualBoxVM_urpyB938qF

Thumbnail goes outside the queue box without the distraction free setting enabled

VirtualBoxVM_7SNWOfCLzI.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 1, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@MarmadileManteater
Copy link
Contributor

This could be accomplished with pure CSS and :has selectors (by checking for .sidebarArea:has(.watchVideoRecommendations)). It is unnecessary to pull the setting value.

@ozrendev
Copy link
Contributor Author

This could be accomplished with pure CSS and :has selectors (by checking for .sidebarArea:has(.watchVideoRecommendations)). It is unnecessary to pull the setting value.

That's a good point but I think the whole solution isn't very robust and probably the wrong way to go about it. Plus I haven't had any time to work on another solution.

@MarmadileManteater
Copy link
Contributor

That is valid. My recommendation, when you come back to it, would be to start over and just see if you can accomplish this without touching anything but css. If you don't have time right now, that is completely understandable. Life is busy.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Apr 22, 2025
auto-merge was automatically disabled April 22, 2025 02:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Utilize empty space for playlist queue when Hide Recommended Videos is enabled

3 participants