Skip to content

Added the loop playback default function#7022

Closed
aziztouhami wants to merge 7 commits intoFreeTubeApp:developmentfrom
aziztouhami:development
Closed

Added the loop playback default function#7022
aziztouhami wants to merge 7 commits intoFreeTubeApp:developmentfrom
aziztouhami:development

Conversation

@aziztouhami
Copy link
Contributor

@aziztouhami aziztouhami commented Mar 17, 2025

Add playback loop default option

Pull Request Type

  • Feature Implementation
  • Bugfix
  • Documentation
  • Other

Description

This pull request adds a default playback loop option to FreeTube. With this feature, users can enable looping for videos automatically, improving the playback experience for those who frequently use the loop functionality.

Changes include:

  • Adding a new setting for enabling/disabling the default loop option.
  • Modifying the player settings component to support this feature.
  • Ensuring the setting persists between sessions.

Screenshots

A screen recording has been provided instead of screenshots.

Screen.Record.for.the.new.feature.mp4

Testing

The code is straightforward, and no additional testing was required.

Desktop

OS: Windows 10 Professionnel
OS Version: 22H2
FreeTube Version: 0.23.2

Additional Context

This feature enhances the user's ability to control playback behavior, making looping more accessible without requiring manual toggling for each video.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 17, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 17, 2025 10:54
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 17, 2025
auto-merge was automatically disabled March 17, 2025 12:00

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 17, 2025 12:00
@aziztouhami
Copy link
Contributor Author

i tried to do all the requested changes

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Mar 18, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loop re-enables it self after user interaction with another player component

VirtualBoxVM_yQpxgbiUmb.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 18, 2025
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled March 18, 2025 12:09

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 18, 2025 12:09
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled March 18, 2025 12:09

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 18, 2025 12:10
auto-merge was automatically disabled March 18, 2025 12:35

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 18, 2025 12:35
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled March 18, 2025 13:13

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 18, 2025 13:13
defaultInvidiousInstance: '',
defaultVolume: 1,
uiScale: 100,
loopPlayback: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A value of false means that by default(in the first time), looping is disabled when a video finishes, it won’t restart automatically

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesnt answer the question

Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
auto-merge was automatically disabled March 18, 2025 13:49

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 18, 2025 13:49
auto-merge was automatically disabled March 21, 2025 21:45

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants