Skip to content

catppuccinMocha card bg color change#7034

Closed
notSelimm wants to merge 2 commits intoFreeTubeApp:developmentfrom
notSelimm:theme-styling
Closed

catppuccinMocha card bg color change#7034
notSelimm wants to merge 2 commits intoFreeTubeApp:developmentfrom
notSelimm:theme-styling

Conversation

@notSelimm
Copy link
Contributor

@notSelimm notSelimm commented Mar 19, 2025

Improved Color Contrast for Uploader Comments in Catppuccin Mocha Theme

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

This pull request changes the color styling of the theme catppuccinMocha at :
CSS properties : card-bg-color and secondary-card-bg-color for .catppuccinMocha
from --card-bg-color: #181825 to -> --card-bg-color: #112a46
from --secondary-card-bg-color: #1e1e2e to -> --secondary-card-bg-color: #acc8e5
This change ensures a correct contrast ratio.

Screenshots

before :
aCapture d'écran 2025-03-19 142812
after :
Capture d'écran 2025-03-19 141300

Testing

The code is straightforward, and no additional testing was required.

Desktop

  • OS: Windows 11
  • OS Version: 23H2
  • FreeTube version: 0.23.2

Additional context


@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 19, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 19, 2025 13:36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the whole theme instead of just the Channel Author's comment

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 19, 2025
auto-merge was automatically disabled March 19, 2025 18:44

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 19, 2025 18:44
@notSelimm
Copy link
Contributor Author

I corrected it thank you for your help.
before :
Capture d'écran 2025-03-19 193730
after :
Capture d'écran 2025-03-19 194023
The channel author's comment name is displayed with a correct background color ensuring the color contrast to be 3.32 (https://coolors.co/contrast-checker/5f5fc9-181825) to meet the WCAG 2's advised 3.1 (https://www.w3.org/WAI/WCAG21/Techniques/general/G183.html)

@efb4f5ff-1298-471a-8973-3d47447115dc

@kommunarr would this suffice or does it has the same issues like #6896

auto-merge was automatically disabled March 21, 2025 21:43

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants