Remove author and authorId from the required list of video keys for playlists #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
previously approved these changes
Mar 28, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Mar 28, 2025
Member
|
I exported playlists -> deleted all playlists -> imported and noticed that the short playlist was included but had no content in it. Should i create a separate issue? |
Collaborator
|
Might as will fix it in this PR... Also since a change is needed I suggest making it commented with explanation like other attributes // These keys are absent in shorts
// 'author',
// 'authorId', |
ChunkyProgrammer
added
PR: changes requested
and removed
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
dismissed
their stale review
see previous comments
absidue
force-pushed
the
fix-shorts-playlist-copy
branch
from
a7499bf to
f8d61af
Compare
absidue
changed the title
absidue
added
PR: waiting for review
PikachuEXE
approved these changes
Apr 10, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 10, 2025
ChunkyProgrammer
approved these changes
Apr 20, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 20, 2025
* development: (25 commits) Remove author and authorId from the required list of video keys for playlists (FreeTubeApp#7083) Translated using Weblate (Odia) Translated using Weblate (Nepali) Translated using Weblate (Hindi) Translated using Weblate (Sinhala) Translated using Weblate (Slovenian) Translated using Weblate (Catalan) Translated using Weblate (Assamese) Translated using Weblate (German) replace icns mac icon with hq one (FreeTubeApp#7212) Fix user-agent and referer for Innertube requests (FreeTubeApp#7213) Use new images (FreeTubeApp#7236) Fix the channel name and ID missing on the channel home tab (FreeTubeApp#7232) Translated using Weblate (Odia) Translated using Weblate (Georgian) Translated using Weblate (Bosnian) Translated using Weblate (Sinhala) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Assamese) Fix live streams not working on the local API (FreeTubeApp#7233) ... # Conflicts: # src/renderer/views/Hashtag/Hashtag.vue
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 20, 2025
…rent * feature/hide-member-only-videos: (25 commits) Remove author and authorId from the required list of video keys for playlists (FreeTubeApp#7083) Translated using Weblate (Odia) Translated using Weblate (Nepali) Translated using Weblate (Hindi) Translated using Weblate (Sinhala) Translated using Weblate (Slovenian) Translated using Weblate (Catalan) Translated using Weblate (Assamese) Translated using Weblate (German) replace icns mac icon with hq one (FreeTubeApp#7212) Fix user-agent and referer for Innertube requests (FreeTubeApp#7213) Use new images (FreeTubeApp#7236) Fix the channel name and ID missing on the channel home tab (FreeTubeApp#7232) Translated using Weblate (Odia) Translated using Weblate (Georgian) Translated using Weblate (Bosnian) Translated using Weblate (Sinhala) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Assamese) Fix live streams not working on the local API (FreeTubeApp#7233) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove author and authorId from the required list of video keys for playlists
Pull Request Type
Related issue
closes #7023
Description
Shorts only playlists don't have any uploader information, so the playlist copy validation code complains about the
authorandauthorIdproperties being missing. This pull request removes those two properties from the required keys allowing those playlists to be copied and imported into FreeTube.Testing
Desktop