Skip to content

Added chapter preview over timeline#8312

Closed
aditya0155 wants to merge 3 commits into
FreeTubeApp:developmentfrom
aditya0155:development
Closed

Added chapter preview over timeline#8312
aditya0155 wants to merge 3 commits into
FreeTubeApp:developmentfrom
aditya0155:development

Conversation

@aditya0155
Copy link
Copy Markdown
Contributor

@aditya0155 aditya0155 commented Nov 19, 2025

Pull Request Type

  • Feature Implementation

Related issue

Description

This PR implements a chapter preview feature that displays the chapter title when hovering over the video timeline. When users move their cursor along the seekbar, a text (chapter label) appears above the timeline showing the title of the chapter at that position.

Screenshots

  • Before:
Before.mp4
  • After:
Updated.mp4

Testing

  1. Visiting Youtube videos having chapters: example:
  1. move their cursor along the seekbar and see if the text appears above the video frame

  2. Go full screen and test for the same.

Desktop

  • OS: Windows 11
  • OS Version: Windows 11 24H2 (OS Build 26100.7171)
  • FreeTube version: 0.23.12

Additional context

  1. Important Edge case fixed:
EDGE_CASE_Fixed.mp4
  • As you can see from the video, the chapter label text does not break when the seekbar is at the extreme ends.

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 19, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 19, 2025 01:31
auto-merge was automatically disabled November 20, 2025 00:08

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 20, 2025 00:08
@SupremeMuhit

This comment has been minimized.

@aditya0155

This comment has been minimized.

@absidue
Copy link
Copy Markdown
Member

absidue commented Nov 20, 2025

@aditya0155 Please integrate these changes into shaka-player itself by submitting a pull request to their repository (you'll obviously need to pull the chapter information from the player directly), instead of implementing a fragile implementation on top of it in FreeTube (this will break if shaka-player makes any changes to their progress bar or thumbnail preview and they have already redesigned them multiple times, so it is definitely possible that it could change again).

@absidue absidue removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 20, 2025
@absidue absidue closed this Nov 20, 2025
auto-merge was automatically disabled November 20, 2025 07:29

Pull request was closed

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Copy Markdown
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 20, 2025

Hi @aditya0155, could you change the placement of it when/if you're going to PR it upstream

Make placement same as YT's placement. Below the thumbnail/timestamp

firefox_rPSmDFkYvk.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Copy Markdown
Member

@aditya0155 its already been implemented shaka-project/shaka-player#9413. Thanks for looking into this though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Show chapter title on seek bar

4 participants