Added chapter preview over timeline#8312
Conversation
eme ends
Head branch was pushed to by a user without write access
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@aditya0155 Please integrate these changes into shaka-player itself by submitting a pull request to their repository (you'll obviously need to pull the chapter information from the player directly), instead of implementing a fragile implementation on top of it in FreeTube (this will break if shaka-player makes any changes to their progress bar or thumbnail preview and they have already redesigned them multiple times, so it is definitely possible that it could change again). |
Pull request was closed
|
Hi @aditya0155, could you change the placement of it when/if you're going to PR it upstream Make placement same as YT's placement. Below the thumbnail/timestamp firefox_rPSmDFkYvk.mp4 |
|
@aditya0155 its already been implemented shaka-project/shaka-player#9413. Thanks for looking into this though! |
Pull Request Type
Related issue
Description
This PR implements a chapter preview feature that displays the chapter title when hovering over the video timeline. When users move their cursor along the seekbar, a text (chapter label) appears above the timeline showing the title of the chapter at that position.
Screenshots
Before.mp4
Updated.mp4
Testing
move their cursor along the seekbar and see if the text appears above the video frame
Go full screen and test for the same.
Desktop
Additional context
EDGE_CASE_Fixed.mp4