Remove unused NS*UsageDescription keys from Info.plist

[absidue]

Pull Request Type

• Bugfix

Description

By default Electron allows all permissions so they include the permission descriptions for audio capture, bluetooth, camera and microphone usage in their macOS Info.plist file. As FreeTube doesn't need those permissions and therefore rejects all requests for them (Our allow list only allows fullscreen, clipboard-sanitized-write and fileSystem), we also don't need the NS*UsageDescription keys for them in our Info.plist file.

Testing

Diff for the FreeTube.app/Contents/Info.plist file in the freetube-*-mac-x64.zip file for the latest nightly build a the time of writing and this test build:

diff --git a/Info-before.plist b/Info-after.plist
index 3e99cf0be..c8340e25d 100644
--- a/Info-before.plist
+++ b/Info-after.plist
@@ -17,7 +17,7 @@
     <key>CFBundlePackageType</key>
     <string>APPL</string>
     <key>CFBundleShortVersionString</key>
-    <string>0.23.13-nightly-7017</string>
+    <string>0.23.13</string>
     <key>CFBundleURLSchemes</key>
     <array>
       <string>freetube</string>
@@ -36,7 +36,7 @@
       </dict>
     </array>
     <key>CFBundleVersion</key>
-    <string>0.23.13-nightly-7017</string>
+    <string>0.23.13</string>
     <key>DTCompiler</key>
     <string>com.apple.compilers.llvm.clang.1_0</string>
     <key>DTSDKBuild</key>
@@ -54,7 +54,7 @@
         <key>algorithm</key>
         <string>SHA256</string>
         <key>hash</key>
-        <string>055f8a1d700087056da0747d1a58c040c32241342abba6b8145c56173ada81fb</string>
+        <string>28d548b6483a1a4aadcf9124058fd41b9e3eb4e615d8be50667713bd6c69fdc1</string>
       </dict>
     </dict>
     <key>LSApplicationCategoryType</key>
@@ -102,22 +102,12 @@
         </dict>
       </dict>
     </dict>
-    <key>NSAudioCaptureUsageDescription</key>
-    <string>This app needs access to audio capture</string>
-    <key>NSBluetoothAlwaysUsageDescription</key>
-    <string>This app needs access to Bluetooth</string>
-    <key>NSBluetoothPeripheralUsageDescription</key>
-    <string>This app needs access to Bluetooth</string>
-    <key>NSCameraUsageDescription</key>
-    <string>This app needs access to the camera</string>
     <key>NSHighResolutionCapable</key>
     <true/>
     <key>NSHumanReadableCopyright</key>
     <string>Copyleft © 2020-2026 freetubeapp@protonmail.com</string>
     <key>NSMainNibFile</key>
     <string>MainMenu</string>
-    <key>NSMicrophoneUsageDescription</key>
-    <string>This app needs access to the microphone</string>
     <key>NSPrefersDisplaySafeAreaCompatibilityMode</key>
     <false/>
     <key>NSPrincipalClass</key>

Desktop

• OS: Windows
• OS Version: 11

[PikachuEXE]

My testing (coz I got mac)

• yarn && yarn build:arm64
• Use text editor to open FreeTube-project-path/build/mac-arm64/FreeTube.app/Contents/Info.plist
• Ensure the new keys in code are absent

[ChunkyProgrammer]

No mac so approving based on Pika's review