Fix menus on small player sizes#8860
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Mar 28, 2026
Merged
Conversation
github-actions
bot
added
the
PR: waiting for review
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
and removed request for
kommunarr
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 22, 2026
PikachuEXE
approved these changes
Mar 23, 2026
ChunkyProgrammer
approved these changes
Mar 28, 2026
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
shaka-player 5 switched the way that menus are handled and buttons need to hide themselves now. In the shaka-player 5 migration pull request I only implemented that for buttons that would be in the menus on desktop screen sizes but on mobile we move a lot more buttons into the menus which was causing the buggy behaviour visible in the screen shots below.
Screenshots
Testing
Resize the window to a very small size and check that when you open submenus such as the quality selector or the playback speed selector, you can only see the buttons that belong to that menu.
Desktop