Ensure popup does not obstruct video title in full screen#8870
Ensure popup does not obstruct video title in full screen#8870FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
caetano-dev
changed the title
There was a problem hiding this comment.
Lgtm, this moves all popups not just the fastforward/backward which is good. Also the placement is moved in all views but seems to be similar as what yt is doing so im ok with it
Bit off topic
I wonder if we should place left/right popups on the left/right middle side like yt
caetano-dev thoughts?
edit: removed offtopic section and will be moved to another PR
efb4f5ff-1298-471a-8973-3d47447115dc
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Head branch was pushed to by a user without write access
This comment was marked as off-topic.
This comment was marked as off-topic.
Head branch was pushed to by a user without write access
caetano-dev
force-pushed
the
moveFastForwardPopup
branch
from
23992e9 to
63d22c0
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
absidue
github-actions
bot
removed
the
PR: waiting for review
|
@caetano-dev thanks for sending this one in. Random thing popedup (you see what i did there :D) again. I tried to play with the opacity of the popup because i feel like its blocking a bit much content but im not getting the desired result. Im either having it to be to solid or too opaque. I think YT has a good balance in this but i think they might be playing with other css stuff. Would it be possible for you to look into this? |
5 participants
Pull Request Type
Related issue
Requested by #7729 (comment), since the previous implementation would appear on top of the titles in full screen mode.
Description
Increases the top scss value for the popup, so that is does not obstruct the title when in full screen.
Screenshots
Testing
Open video with a long title in full screen
Use left or right arrows
See the pop up below the title
Desktop