fix: (follow up of #8317 PR) respect Hide Sharing Actions setting for community posts#8891
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Mar 28, 2026
Conversation
1 task
absidue
approved these changes
Mar 27, 2026
PikachuEXE
approved these changes
Mar 27, 2026
ChunkyProgrammer
approved these changes
Mar 28, 2026
Member
|
@aditya0155 thanks for sending in this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Follow-up to #8317 -> addresses reviewer feedback regarding the "Hide Sharing Actions" setting.
closes #7136 (the share button feature was added in #8317, this PR fixes a missing setting check)
Description
The share button I added to community posts in #8317 doesn't get hidden when "Hide Sharing Actions" is enabled in Distraction Free settings. This fixes that by adding the same
v-ifcheck used by the other share buttons throughout the app.Screenshots
Hide-Setting-Working.mp4
Testing
https://www.youtube.com/channel/UCQeRaTukNYft1_6AZPACnog)Desktop
Additional context
This is a minimal 2-line change:
v-if="!hideSharingActions"to the<FtShareButton>in the templatestore.getters.getHideSharingActionsNo other files need modification -> the store getter is auto-generated from the existing hideSharingActions key in settings.js.